Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add K8s authors header #25

Open
mneverov opened this issue Jul 31, 2024 · 4 comments
Open

Add K8s authors header #25

mneverov opened this issue Jul 31, 2024 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@mneverov
Copy link
Member

mneverov commented Jul 31, 2024 •
edited
Loading

They Copyright 2023 The Kubernetes Authors. should be present in all files, also in boilerplate.
@aojea
Copy link
Contributor

aojea commented Jul 31, 2024 •
edited
Loading

why?

this project is under kubernetes so it has to keep the copyright, now I notice we have this empty https://github.com/kubernetes-sigs/node-ipam-controller/blob/main/hack/boilerplate.go.txt

https://github.com/kubernetes-sigs/node-ipam-controller/blob/main/CONTRIBUTING.md#contributing-guidelines

@mneverov
Copy link
Member Author

Currently, only few files have this header. I checked projects under k8s-sigs and some have the header, and some don't.
I'm for consistency either way. Let's add the header to all files and boilerplate too.

@mneverov mneverov changed the title Remove K8s authors header Add K8s authors header Jul 31, 2024
@mneverov
Copy link
Member Author

Updated the description to add the headers.

@mneverov mneverov mentioned this issue Jul 31, 2024
Merged
@aojea
Copy link
Contributor

aojea commented Jul 31, 2024

checked projects under k8s-sigs and some have the header, and some don't.
I'm for consistency either way.

heh :) is not surprising :)

@mneverov mneverov added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mneverov @aojea