Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add leader-election option #20

Merged
merged 12 commits into from
Aug 1, 2024
Merged

feat: add leader-election option #20

merged 12 commits into from
Aug 1, 2024

Conversation

ugur99
Copy link
Contributor

@ugur99 ugur99 commented Jul 27, 2024

This PR introduces a leader election mechanism for the controller, which could be critical for high availability of the service in large clusters.

@ugur99
feat: add leader-election option
7277f25 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ugur99!

It looks like this is your first PR to kubernetes-sigs/node-ipam-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-ipam-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 27, 2024
@ugur99
feat: add leader-election option - small fix for helm chart
aae6e93 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
@ugur99
feat: add leader-election option - fix log line
e48093b 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
aojea
aojea reviewed Jul 29, 2024
View reviewed changes
main.go Outdated Show resolved Hide resolved
@aojea
Copy link
Contributor

aojea commented Jul 29, 2024

overall lgtm but I didn't do a thorughful review
/assign @sarveshr7 @mneverov

Do you mind doing the final review?

aojea
aojea reviewed Jul 29, 2024
View reviewed changes
main.go Show resolved Hide resolved
mneverov
mneverov requested changes Jul 30, 2024
View reviewed changes
pkg/leaderelection/leaderelection.go Outdated Show resolved Hide resolved
pkg/leaderelection/leaderelection.go Outdated Show resolved Hide resolved
pkg/leaderelection/leaderelection.go Outdated Show resolved Hide resolved
pkg/leaderelection/leaderelection.go Show resolved Hide resolved
charts/node-ipam-controller/templates/serviceaccount.yaml Outdated Show resolved Hide resolved
@ugur99
fix: helm chart naming convention and leader election default values
620cc9f 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
@ugur99
fix: leader-election options and some other fixes
ee5a912 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
@ugur99 ugur99 requested a review from mneverov July 30, 2024 20:46
@ugur99
fix: revert hostNetwork value
cf07f20 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
@ugur99
fix: revert replicaCount value
02d4754 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
mneverov
mneverov requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@mneverov mneverov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits only. Already looks amazing.

LeaderElection has an option to specify health checks adapter. I don't want to hold this PR for longer, so @ugur99 could you please create an issue to investigate if the adapter can be useful?

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
charts/node-ipam-controller/templates/serviceaccount.yaml Outdated Show resolved Hide resolved
charts/node-ipam-controller/templates/serviceaccount.yaml Outdated Show resolved Hide resolved
charts/node-ipam-controller/templates/serviceaccount.yaml Outdated Show resolved Hide resolved
@ugur99
fix: graceful shutdown and some helm templates
d50a130 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
@ugur99 ugur99 mentioned this pull request Jul 31, 2024
Open
@ugur99 ugur99 requested a review from mneverov July 31, 2024 18:47
mneverov
mneverov requested changes Jul 31, 2024
View reviewed changes
charts/node-ipam-controller/templates/deployment.yaml Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@ugur99
fix: graceful shutdown and some helm templates
c58b230 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
@ugur99
fix: deployment helm template
4d4e670 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
@ugur99 ugur99 requested a review from mneverov July 31, 2024 20:08
mneverov
mneverov requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@mneverov mneverov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

charts/node-ipam-controller/templates/deployment.yaml Show resolved Hide resolved
mneverov
mneverov requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@mneverov mneverov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because the whole reconciliation loop run in a separate goroutine, so the main function exits immediately

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@ugur99
fix: synchronous execution instead of new goroutines
c9237ab 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
@ugur99 ugur99 requested a review from mneverov August 1, 2024 18:34
@mneverov
Copy link
Member

mneverov commented Aug 1, 2024

lgtm

@mneverov mneverov added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mneverov, ugur99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1323bc8 into kubernetes-sigs:main Aug 1, 2024
8 checks passed
@mneverov
Copy link
Member

mneverov commented Aug 1, 2024

@ugur99 thanks for your contribution!

@ugur99
Copy link
Contributor Author

ugur99 commented Aug 1, 2024

thank you for your support and quick action @mneverov @aojea

@mneverov mneverov mentioned this pull request Sep 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@mneverov mneverov mneverov approved these changes

@sarveshr7 sarveshr7 Awaiting requested review from sarveshr7

Assignees

@mneverov mneverov

@sarveshr7 sarveshr7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ugur99 @k8s-ci-robot @aojea @mneverov @sarveshr7