Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert fork of nozzle/throttle #111

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

puerco
Copy link
Member

@puerco puerco commented Jul 25, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR reverts our fork of the github.com/nozzle/throttler package. We assumed by mistake
that the project was not maintained anymore but we now found out it is.

Which issue(s) this PR fixes:

Follow up to: #108

Special notes for your reviewer:

/cc @derekperkins for visibility :)

Does this PR introduce a user-facing change?

Reverted fork of nozzle/throttler to release-utils (see https://github.com/kubernetes-sigs/release-utils/pull/108#issuecomment-2245241477  )

This commit reverts the import of a fork of nozzle/throttler. We
mistakenly assumed the project was not maintained but happily
found out it is not.

Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
this commit changes the http package to
use the upstream package nozzle/throttler

Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 25, 2024
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 25, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 25, 2024
Copy link

@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 943a605 into kubernetes-sigs:main Jul 25, 2024
4 checks passed
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge LGTM :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, puerco, Verolop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Verolop,justaugustus,puerco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants