Support adding external finalizer for static provisioned volumes #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
jsafrane
reviewed
Oct 31, 2022
controller/controller.go
Outdated
| volumeFinalizers, modified = addFinalizer(volumeFinalizers, finalizerPV) | ||
| } | ||
| // For statically provisioned volumes remove the external finalizer if the volume is not in a Bound state | ||
| if volume.Status.Phase != v1.VolumeBound { |
There was a problem hiding this comment.
(starting a separate "thread")
If you remove this check, then the code for dynamic and static provisioning will be very similar. I wonder if there is room for improvement and removing the special case. Like if ctrl.addFinalizer && reclaimPolicy == v1.PersistentVolumeReclaimDelete && volume.DeletionTimestamp == nil && (isDynamic || phase == Bound)
Signed-off-by: Deepak Kinni <[email protected]>
deepakkinni
force-pushed
the
pv_reclaim_Sept_22_v1
branch
from
5182976
to
ee0d78c
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepakkinni, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support adding the new finalizer
external-provisioner.volume.kubernetes.io/finalizeron statically provisioned volumesThe finalizer will be added to the following volumes:
For (2) and (3), the finalizer will be added only if the volume is in a
Boundstate and removed if the volume changes to any other state apart fromBoundSigned-off-by: Deepak Kinni [email protected]