-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test framework #3651
Add e2e test framework #3651
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benmoss The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks @benmoss , this is gonna take some time for me to go through. just a heads up ;) |
The main changes are in |
that makes sense to me. i want to spend some time thinking about how we integrate this into the wider testing infra. i like that this is self-contained and we could just build by importing, i guess the next steps will be to figure out if we should promote subdirectories in the cloudproviders to contain their implementations. |
@benmoss: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hey Ben, just wanted to give a heads up. i am still working my way through this pr. currently trying to get everything working with the cluster-api-autoscaler-provider. it's going slow but i think most of it is making sense. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
There seems to be no progress on the PR. Closing. Feel free to reopen once needed. |
@mwielgus i would like to continue with this work, but at this point i think it's best to just open a new pr when i am ready to move forward. |
Builds off of #3566.
Adds adapted tests from the e2e suite. Right now there only a subset but ideally over time we can backfill additional coverage as we figure out how to do it in vendor agnostic ways.
cc @elmiko