Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test framework #3651

Closed
wants to merge 4 commits into from
Closed

Conversation

benmoss
Copy link
Member

@benmoss benmoss commented Oct 29, 2020

Builds off of #3566.

Adds adapted tests from the e2e suite. Right now there only a subset but ideally over time we can backfill additional coverage as we figure out how to do it in vendor agnostic ways.

cc @elmiko

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benmoss
To complete the pull request process, please assign aleksandra-malinowska after the PR has been reviewed.
You can assign the PR to them by writing /assign @aleksandra-malinowska in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 29, 2020
@elmiko
Copy link
Contributor

elmiko commented Oct 29, 2020

thanks @benmoss , this is gonna take some time for me to go through. just a heads up ;)

@benmoss
Copy link
Member Author

benmoss commented Oct 29, 2020

The main changes are in test/framework, the rest is just noise. We might want to consider dropping the vendor/ directory as part of #3566 since it generates a bunch of commit noise

@elmiko
Copy link
Contributor

elmiko commented Oct 29, 2020

We might want to consider dropping the vendor/ directory as part of #3566 since it generates a bunch of commit noise

that makes sense to me.

i want to spend some time thinking about how we integrate this into the wider testing infra. i like that this is self-contained and we could just build by importing, i guess the next steps will be to figure out if we should promote subdirectories in the cloudproviders to contain their implementations.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2020
@k8s-ci-robot
Copy link
Contributor

@benmoss: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Contributor

elmiko commented Dec 14, 2020

hey Ben, just wanted to give a heads up. i am still working my way through this pr. currently trying to get everything working with the cluster-api-autoscaler-provider. it's going slow but i think most of it is making sense.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2021
@elmiko
Copy link
Contributor

elmiko commented Mar 15, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2021
@mwielgus
Copy link
Contributor

mwielgus commented Jul 2, 2021

There seems to be no progress on the PR. Closing. Feel free to reopen once needed.

@mwielgus mwielgus closed this Jul 2, 2021
@elmiko
Copy link
Contributor

elmiko commented Jul 6, 2021

@mwielgus i would like to continue with this work, but at this point i think it's best to just open a new pr when i am ready to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants