Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cce verion and move sdk to go mod #4714

Closed
wants to merge 3 commits into from
Closed

added cce verion and move sdk to go mod #4714

wants to merge 3 commits into from

Conversation

wangshiqi308
Copy link
Contributor

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind feature
/kind cleanup

What this PR does / why we need it:

  1. We had to copy the SDK file before because the go module was not enabled(see cluster autoscaler can not build when enable go mod #3146), but in this PR we put our SDK in the go.mod file
  2. Added CCE version CA to servicestage folder.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wangshiqi308
To complete the pull request process, please assign feiskyer after the PR has been reviewed.
You can assign the PR to them by writing /assign @feiskyer in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangshiqi308
Copy link
Contributor Author

/assign @RainbowMango

@RainbowMango
Copy link
Member

I guess after putting SDK to go.mod, the original SDL should be removed(actually moved to vendor), why not?

@wangshiqi308
Copy link
Contributor Author

it couldn't be compiled without running go mod vendor

@RainbowMango
Copy link
Member

it couldn't be compiled without running go mod vendor

Why not vendor the SDK? Is there something wrong?

@wangshiqi308
Copy link
Contributor Author

it could be built with flag -mod=mod, but it is not in the Makefile, I'm not sure if it could pass the Test, I will have a try.

@wangshiqi308
Copy link
Contributor Author

@RainbowMango
Copy link
Member

Hi @wangshiqi308 It is recommended to split this to two PRs. First one is dedicated to the vendor thing and the other one for the rest. (Too many changed files and hard to review).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants