-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added cce verion and move sdk to go mod #4714
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wangshiqi308 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @RainbowMango |
I guess after putting SDK to |
it couldn't be compiled without running |
Why not vendor the SDK? Is there something wrong? |
it could be built with flag |
It couldn't pass test https://github.com/kubernetes/autoscaler/runs/5342369544?check_suite_focus=true |
Hi @wangshiqi308 It is recommended to split this to two PRs. First one is dedicated to the vendor thing and the other one for the rest. (Too many changed files and hard to review). |
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind feature
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: