-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix expectedToRegister to respect instances with nil status #6528
Fix expectedToRegister to respect instances with nil status #6528
Conversation
|
Welcome @yarinm! |
/lgtm |
Thanks! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: x13n, yarinm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yarinm |
To check EasyCLA /easycla |
@Shubham82 I'm waiting for the legal department on the firm I'm working for this, I hope to get the necessary approvals in the next few days |
/easycla |
@Shubham82 We've signed the CLA, can you please merge the PR? |
Shouldn't this be cherry-picked into 1.28 and 1.29? |
@tallaxes, I think we can fix this in the previous supported releases. |
@tallaxes I will open PRs to backport this fix into CA 1.28 and CA 1.29. |
…nces with nil status into CA1.28
…nces with nil status into CA1.29
…am-cluster-autoscaler-release-1.28 Backport #6528 [CA] Fix expectedToRegister to respect instances with nil status into CA1.28
…am-cluster-autoscaler-release-1.29 Backport #6528 [CA] Fix expectedToRegister to respect instances with nil status into CA1.29
Fix for #6524