-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vpa-{updater,recommender}: Add support for leader election #6985
vpa-{updater,recommender}: Add support for leader election #6985
Conversation
Skipping CI for Draft Pull Request. |
d97023d
to
a2a0250
Compare
b32a058
to
d5c12cf
Compare
/cc @kwiesmueller |
/assign @voelzmo @raywainman |
I build and tested this locally, and it all works as expected. Very nice, this is something I've also been wanting. |
/lgtm Thanks! Great catch of taking care of the |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov, voelzmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for leader election in vpa-updater and vpa-recommender.
Which issue(s) this PR fixes:
Fixes #6846
Special notes for your reviewer:
This PR is strongly inspired by how leader election is built for the cluster-autoscaler.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: