refactor: upstream Azure managed instance cache refactor #7116
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
|
Hi @comtalyst. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XXL
comtalyst
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/test pull-cluster-autoscaler-e2e-azure |
| func isOperationNotAllowed(rerr *retry.Error) bool { | ||
| return rerr != nil && rerr.ServiceErrorCode() == retry.OperationNotAllowed | ||
| } |
There was a problem hiding this comment.
We should move these to azure sdk for go extensions
There was a problem hiding this comment.
Do you mean we have an equivalent of this in a library?
Also, I don't think small things like this is necessary to be abstracted in the first place.
But, whatever idea we have, let's save it for post-defork quality improvement. It doesn't look worth it to do that now---in this case.
k8s-ci-robot
added
the
approved
|
just double checking approval works, still need to give a proper review |
cluster-autoscaler/cloudprovider/azure/azure_cloud_provider_test.go
Outdated
Show resolved
Hide resolved
comtalyst
force-pushed
the
comtalyst/azure-managed-instance-cache-master
branch
from
63d921f
to
3cf98d7
Compare
comtalyst
force-pushed
the
comtalyst/azure-managed-instance-cache-master
branch
from
3cf98d7
to
98257a8
Compare
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bryce-Soghigian, comtalyst The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
"Refactor" as a part of fork-upstream (managed-selfhosted) realignment. Should not have any breaking changes.
This codebases realignment will simplify the logistics between the two, cutting a significant portion of maintenance cost.
This PR specifically focus on instance caching.
There will be a separate effort focusing on improve code quality, rather than realigning codebase.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Most changes are merely refactor. Also include small fixes to refresh instance cache in more cases that should be required. Also include support for currently managed-exclusive flags (e.g.,
EnableDetailedCSEMessage).There are similar PRs out on version release branches as well. Should be near identical.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: