-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] add support for podLabels and podAnnotations to occm and cinder-csi-plugin charts #2533
base: master
Are you sure you want to change the base?
[charts] add support for podLabels and podAnnotations to occm and cinder-csi-plugin charts #2533
Conversation
Welcome @roehlc! |
Hi @roehlc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we wrap all these into some template functions, so that we don't need to write whole with-toYaml-end? Also a bunch of remarks inline.
charts/openstack-cloud-controller-manager/templates/_helpers.tpl
Outdated
Show resolved
Hide resolved
0478b3d
to
5b4f4a6
Compare
I added helper templates to remove the need to write "with-toYaml-end" and addressed the remarks inline. @dulek Would you please take another look? |
/lgtm Leaving approval for someone more experienced with Helm. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
5b4f4a6
to
0afb2a6
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0afb2a6
to
b4eba8b
Compare
b4eba8b
to
68a3a4c
Compare
needed if we want to be consistent with commonAnnotations defined in the occm chart
This reverts commit 7a5bfcd.
68a3a4c
to
1a5b42c
Compare
/remove-lifecycle stale |
/retest |
/lgtm |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
podLabels
andpodAnnotations
in the openstack-cloud-controller-manager and cinder-csi-plugin chartscommonAnnotations
are applied in cinder-csi-plugin chartWhich issue this PR fixes(if applicable):
Special notes for reviewers:
Release note: