Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A proposal for bootstrap discovery. #189

Merged
merged 1 commit into from
Dec 17, 2016

Conversation

jbeda
Copy link
Contributor

@jbeda jbeda commented Dec 17, 2016

This is kubernetes/kubernetes#30707 ported over to the community repo.

This has been discussed at length and has been LGTM'd.

/cc (from other issue) @dgoodwin @timothysc @errordeveloper @liggitt @smarterclayton @pires

@pires
Copy link
Contributor

pires commented Jan 11, 2017

@jbeda an issue arose when token ID is not lowercase or/and doesn't respect DNS naming rules and we need your guidance in order to determine if a fix should be in place. This affects both kubeadm and, we believe, your PR kubernetes/kubernetes#36101.

/cc @liggitt @luxas

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this pull request Feb 11, 2017
Automatic merge from submit-queue (batch tested with PRs 38252, 41122, 36101, 41017, 41264)

BootstrapSigner and TokenCleaner controllers

This is part of kubernetes/enhancements#130 and is an implementation of kubernetes/community#189.

Work that needs to be done yet in this PR:
* [ ] ~~e2e tests~~ Will come in new PR.
* [x] flag to disable this by default

```release-note
Native support for token based bootstrap flow.  This includes signing a well known ConfigMap in the `kube-public` namespace and cleaning out expired tokens.
```

@kubernetes/sig-cluster-lifecycle @dgoodwin @roberthbailey @mikedanese
ruebenramirez pushed a commit to ruebenramirez/community that referenced this pull request Apr 22, 2017
shyamjvs pushed a commit to shyamjvs/community that referenced this pull request Sep 22, 2017
akhilerm pushed a commit to akhilerm/apimachinery that referenced this pull request Sep 20, 2022
Automatic merge from submit-queue (batch tested with PRs 38252, 41122, 36101, 41017, 41264)

BootstrapSigner and TokenCleaner controllers

This is part of kubernetes/enhancements#130 and is an implementation of kubernetes/community#189.

Work that needs to be done yet in this PR:
* [ ] ~~e2e tests~~ Will come in new PR.
* [x] flag to disable this by default

```release-note
Native support for token based bootstrap flow.  This includes signing a well known ConfigMap in the `kube-public` namespace and cleaning out expired tokens.
```

@kubernetes/sig-cluster-lifecycle @dgoodwin @roberthbailey @mikedanese

Kubernetes-commit: 866aa735912e548a73ff54c4b6c9b338adfa19e3
danehans pushed a commit to danehans/community that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants