-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documment logging formats #6255
Conversation
Looks good, thanks for capturing this. |
3117f55
to
c430dcb
Compare
c430dcb
to
eee16c8
Compare
@pohly addressed all comments. |
Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>
eee16c8
to
1317bc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
During recent WG Structured Logging meeting we went into discussion what features/changes should be make in specific problem. This lead us to agree that we need some high level guide about what changes make sense in which format.
This is draft PR that I started writing to document goals of each logging format.
/cc @ehashman @pohly