Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-release: Add subproject leads as reviewers/approvers for subdirs #7926

Merged
merged 1 commit into from
Jun 3, 2024
Merged

sig-release: Add subproject leads as reviewers/approvers for subdirs #7926

merged 1 commit into from
Jun 3, 2024

Conversation

justaugustus
Copy link
Member

Part of kubernetes/sig-release#2516.

Grants:

  • Reviewer:
    • /sig-release
  • Approver:
    • /communication/slack-config/sig-release
    • /contributors/devel/sig-release

Context: There are some existing PRs e.g., #7919, #7600 that could be reviewed/approved by subproject leads, now that the role exists.

cc: @kubernetes/sig-release-leads @gracenng @katcosgrove @xmudrii

@justaugustus
sig-release: Add subproject leads as reviewers/approvers for subdirs
d163f44 
Grants:

- Reviewer:
  - /sig-release
- Approver:
  - /communication/slack-config/sig-release
  - /contributors/devel/sig-release

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added area/community-management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/developer-guide Issues or PRs related to the developer guide area/slack-management Issues or PRs related to the Slack Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2024
cpanato
cpanato approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0a7124e into kubernetes:master Jun 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/developer-guide Issues or PRs related to the developer guide area/slack-management Issues or PRs related to the Slack Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justaugustus @k8s-ci-robot @cpanato