Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributors: Add SIG ContribEx as owners #7930

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

justaugustus
Copy link
Member

@kubernetes/sig-contributor-experience-leads — I've noticed a few PRs e.g., #7691, #7923 that are flagging @kubernetes/steering-committee members for review, when we likely don't need to be in the path.

Raising this PR draw attention to the approval gap.
Let me know if you want me to extend it to other directories or if you're happy to carry any updates as follow-ups.

@k8s-ci-robot k8s-ci-robot requested a review from kaslin June 4, 2024 21:23
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 4, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2024
@justaugustus
Copy link
Member Author

/hold until SIG ContribEx reviews

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2024
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
with SIG ContribEx hat on

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, MadhavJivrajani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MadhavJivrajani,justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member

pacoxu commented Jun 6, 2024

/hold until SIG ContribEx reviews

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2024
@MadhavJivrajani
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2024
@MadhavJivrajani
Copy link
Contributor

For other leads in case they have any comments, can unhold after one more ack.

@mbianchidev
Copy link
Member

Ah, didn't notice that my PR was set for the steering committee to review, whoops. Sorry about that.

Btw, in case someone (else) wants to merge it feel free, we have had some people wonder how to sign the CLA when they start contributing :)

@Priyankasaggu11929
Copy link
Member

/lgtm (as ContribEx TL)

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 76c5b63 into kubernetes:master Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants