Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Exposing Storage Metrics #855

Closed
wants to merge 5 commits into from

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Jul 26, 2017

This proposal is exploring ways of exposing storage metrics to users

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2017
@jingxu97 jingxu97 self-assigned this Jul 26, 2017
@jingxu97 jingxu97 added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jul 26, 2017
@jingxu97 jingxu97 added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Aug 2, 2017
@jingxu97
Copy link
Contributor Author

jingxu97 commented Aug 2, 2017

cc @kubernetes/sig-instrumentation-feature-requests @kubernetes/sig-storage-feature-requests


| Metric name | Metric type | Labels/tags |
|-------------|-------------|-------------|
| volume_stats_capacityBytes | Gauge | namespace=\<persistentvolumeclaim-namespace\> <br/> persistentvolumeclaim=\<persistentvolumeclaim-name\> <br/> persistentvolume=\<persistentvolume-name\> |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mixed snake and camel case

}

// PVCReference contains enough information to locate the referenced PVC.
type PodReference struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment says PVCReference, struct name is PodReference

}

// PVReference contains enough information to locate the referenced PV.
type PodReference struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment says PVReference, struct name is PodReference

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 15, 2017
@jingxu97 jingxu97 changed the title [WIP] Proposal for Exposing Storage Metrics Proposal for Exposing Storage Metrics Aug 29, 2017


## Goals
The gola of this proposal is to expose storage usage metrics to users for monitoring their storage systems.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this feature on pod-level ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the metric is per volume. Could you explain what you mean by "pod-level"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spell: s/gola/goal/

k8s-github-robot pushed a commit that referenced this pull request Aug 30, 2017
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](#855)

Feature: [#363](kubernetes/enhancements#363)
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this pull request Sep 3, 2017
Automatic merge from submit-queue

Expose PVC metrics via kubelet prometheus

This depends on #51448, opening early though. second commit is mine and mostly a copy/paste job.

implements metrics listed in here kubernetes/community#855 following method here kubernetes/community#930 (comment)

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: kubernetes/enhancements#363

**Special notes for your reviewer**:

**Release note**:

```release-note
PersistentVolumeClaim metrics like "volume_stats_inodes" and "volume_stats_capacity_bytes" are now reported via kubelet prometheus
```
@piosz piosz self-assigned this Sep 7, 2017
@piosz
Copy link
Member

piosz commented Sep 7, 2017

Is this ready for review? I still can see [WIP] tag in the first line of the doc.


### volume usage information indexed by PVC/PV in Kubelet Summary API

The basic idea is to cache PVC and the volume information in kubelet volume manager which is similar to caching the pod and volume information. In Summary API, In Summary API, we could add PVC and PV references into VolumeStats which is included in PodStats.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: double "In Summary API"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: incomplete sentence? "The second part is to register the volume metrics to ."

erinboyd pushed a commit to erinboyd/community that referenced this pull request Oct 23, 2017
Flushes out details for part 1 of the changes described in
kubernetes#855

Feature: kubernetes/enhancements#363
erinboyd pushed a commit to erinboyd/community that referenced this pull request Oct 23, 2017
Flushes out details for part 1 of the changes described in
kubernetes#855

Feature: kubernetes/enhancements#363
@k8s-github-robot
Copy link

This PR hasn't been active in 61 days. It will be closed in 28 days (Dec 16, 2017).

cc @jingxu97 @piosz

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

@k8s-github-robot k8s-github-robot added the kind/design Categorizes issue or PR as related to design. label Feb 6, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 17, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

justaugustus pushed a commit to justaugustus/enhancements that referenced this pull request Sep 3, 2018
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes#363
justaugustus pushed a commit to justaugustus/enhancements that referenced this pull request Sep 3, 2018
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[kubernetes#855](kubernetes/community#855)

Feature: [kubernetes#363](kubernetes#363)
@dioguerra
Copy link

Status?
Was it done?

@nodesocket
Copy link

nodesocket commented Jan 29, 2020

👍 I'd like to view how much of a persistent volume is in use and don't know of a way.

MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this pull request Nov 30, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this pull request Nov 30, 2021
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](kubernetes/community#855)

Feature: [#363](kubernetes/enhancements#363)
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this pull request Nov 30, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this pull request Dec 1, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this pull request Dec 1, 2021
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](kubernetes/community#855)

Feature: [#363](kubernetes/enhancements#363)
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this pull request Dec 1, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this pull request Dec 1, 2021
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](kubernetes/community#855)

Feature: [#363](kubernetes/enhancements#363)
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this pull request Dec 1, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this pull request Dec 1, 2021
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](kubernetes/community#855)

Feature: [#363](kubernetes/enhancements#363)
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this pull request Dec 1, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this pull request Dec 1, 2021
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](kubernetes/community#855)

Feature: [#363](kubernetes/enhancements#363)
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this pull request Dec 1, 2021
Flushes out details for part 1 of the changes described in
kubernetes/community#855

Feature: kubernetes/enhancements#363
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this pull request Dec 1, 2021
Automatic merge from submit-queue

Proposal for adding PVC info to VolumeStats

Flushes out details for part 1 of the changes described in
[#855](kubernetes/community#855)

Feature: [#363](kubernetes/enhancements#363)
danehans pushed a commit to danehans/community that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.