Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate to use go mod in Travis CI #3936

Closed
shu-mutou opened this issue Jun 17, 2019 · 4 comments · Fixed by #3938
Closed

Investigate to use go mod in Travis CI #3936

shu-mutou opened this issue Jun 17, 2019 · 4 comments · Fixed by #3938
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.

Comments

@shu-mutou
Copy link
Contributor

npm ci seems to update go.mod file to use latest.
To use go mod, we need to investigate more.

BTW, Error about src/app/backend/dashboard.go:158:26: undefined: prometheus.Handler is caused due to prometheus.Handler() was removed in latest (1.0.0) prometheus/client-golang.

@shu-mutou shu-mutou added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jun 17, 2019
@eloyekunle
Copy link
Contributor

eloyekunle commented Jun 17, 2019

In the package.json postinstall, I think we should download a specific version of golangci-lint (via curl), instead of via go get. Coincidentally, that's what's recommended by the golangci-lint team.

@shu-mutou Our prometheus/client_golang is currently fixed at v0.9.2 (here). If npm ci is updating the version during the build, then #3938 should fix it.

@shu-mutou
Copy link
Contributor Author

I understood we should not use go get to install tools.
In the future, if we would want to add the other tools written in golang, we may meet same problem.
Can we move export GO111MODULE=on just before npm ci? If so, I think we can use go get before setting GO111MODULE.
Also, should we set GO111MODULE in our local environments?

@maciaszczykm
Copy link
Member

@shu-mutou
Copy link
Contributor Author

Oh, yes! You're right!! We can use go get before it. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants