Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download golangci-lint via curl #3938

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

eloyekunle
Copy link
Contributor

@eloyekunle eloyekunle commented Jun 17, 2019

In the package.json postinstall, it downloads a specific version of golangci-lint (via curl), instead of via go get. Coincidentally, that's what's recommended by the golangci-lint team.

Closes #3936
Closes #3935

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2019
@k8s-ci-robot k8s-ci-robot requested review from PeWu and rf232 June 17, 2019 12:54
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #3938 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3938      +/-   ##
=========================================
- Coverage   46.63%   46.6%   -0.04%     
=========================================
  Files         176     176              
  Lines        8133    8133              
  Branches       71      71              
=========================================
- Hits         3793    3790       -3     
- Misses       4106    4110       +4     
+ Partials      234     233       -1
Impacted Files Coverage Δ
src/app/backend/sync/secret.go 70.29% <0%> (-2.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 708e606...6056f38. Read the comment docs.

@eloyekunle
Copy link
Contributor Author

/assign shu-mutou maciaszczykm

@maciaszczykm
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 17, 2019
@maciaszczykm
Copy link
Member

/hold

For @shu-mutou to cancel it.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2019
@maciaszczykm
Copy link
Member

@shu-mutou Can you verify this one?

@shu-mutou
Copy link
Contributor

@maciaszczykm I'm considering how we should set environments including local.

@shu-mutou
Copy link
Contributor

shu-mutou commented Jun 18, 2019

/lgtm
To restart quickly our ci, this seems good to me.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eloyekunle, maciaszczykm, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maciaszczykm
Copy link
Member

/hold cancel

Let's focus on local env then.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 28bef92 into kubernetes:master Jun 18, 2019
@shu-mutou
Copy link
Contributor

@eloyekunle Could you write draft to update following, and then request maintainers to update? https://github.com/kubernetes/dashboard/wiki/Dependency-management#go-dependencies .

@eloyekunle eloyekunle deleted the fix/curl-golangci-lint branch June 19, 2019 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate to use go mod in Travis CI
4 participants