-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download golangci-lint via curl #3938
Download golangci-lint via curl #3938
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3938 +/- ##
=========================================
- Coverage 46.63% 46.6% -0.04%
=========================================
Files 176 176
Lines 8133 8133
Branches 71 71
=========================================
- Hits 3793 3790 -3
- Misses 4106 4110 +4
+ Partials 234 233 -1
Continue to review full report at Codecov.
|
/assign shu-mutou maciaszczykm |
/approve |
/hold For @shu-mutou to cancel it. |
@shu-mutou Can you verify this one? |
@maciaszczykm I'm considering how we should set environments including local. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eloyekunle, maciaszczykm, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel Let's focus on local env then. |
@eloyekunle Could you write draft to update following, and then request maintainers to update? https://github.com/kubernetes/dashboard/wiki/Dependency-management#go-dependencies . |
In the
package.json
postinstall
, it downloads a specific version ofgolangci-lint
(viacurl
), instead of viago get
. Coincidentally, that's what's recommended by thegolangci-lint
team.Closes #3936
Closes #3935