Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毃 Helm metrics-server Deployment uses web env #9054

Closed
regnaio opened this issue May 17, 2024 · 3 comments
Closed

馃毃 Helm metrics-server Deployment uses web env #9054

regnaio opened this issue May 17, 2024 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@regnaio
Copy link

regnaio commented May 17, 2024

https://github.com/kubernetes/dashboard/blob/master/charts/kubernetes-dashboard/templates/deployments/metrics-scraper.yaml#L64

I believe that

{{- with .Values.web.containers.env }}

should be replaced with:

{{- with .Values.metricsScraper.containers.env }}
@regnaio regnaio added the kind/bug Categorizes issue or PR as related to a bug. label May 17, 2024
@manojks1999
Copy link

Hi @regnaio ,
Made changes in the config file, here is the PR: #9057

@floreks
Copy link
Member

floreks commented May 27, 2024

/close

@k8s-ci-robot
Copy link
Contributor

@floreks: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants