Logs Auto Scroll

[eloyekunle]

Update the Logs view to support autoscroll when Logs refresh.

Closes #2610

[codecov]

Codecov Report

Merging #3561 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3561      +/-   ##
==========================================
+ Coverage   48.38%   48.42%   +0.03%     
==========================================
  Files         165      165              
  Lines        8000     8000              
  Branches       24       24              
==========================================
+ Hits         3871     3874       +3     
+ Misses       3862     3858       -4     
- Partials      267      268       +1

Impacted Files	Coverage Δ
src/app/backend/sync/secret.go	73.26% <0%> (+2.97%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8eb99...9c7e1e3. Read the comment docs.

[eloyekunle]

/assign maciaszczykm

[maciaszczykm]

It does not solve #3509. The original issue with more context is #1083. I will take a look tomorrow.

[jeefy]

Agreeing with @maciaszczykm -- This doesn't solve #3509, it only solves #2610

I'd lgtm it once we clarify that auto-scrolling was the only intent for this PR.

Thanks!

[maciaszczykm]

Works fine for page refresh, but not when switching pages. It is quote uncomfortable at the moment, but newest logs are at the end. Can you scroll also on page changes?

And remove #3509 from fixed issues please.

[eloyekunle]

I've removed #3509, I'll have to thrash that on another PR.

The current behavior is it scrolls only when the user is already at the bottom of the logs viewer. This is to avoid a situation where you're trying to read something higher up in the page but the logs keep scrolling down during auto-refresh.

Currently, when you switch pages, you arrive at the top of the target page so it doesn't scroll because you're not at the bottom.

What do you think?

[floreks]

I'd say that on page change to next one we should stay on top, but on page change to the previous one, we should go to the bottom to make it feel like you can continue reading without scrolling manually.

As for the autoscroll to bottom when using autorefresh, I would maybe add new option to follow the logs. Maybe something like travis does?

[eloyekunle]

Okay, new changes:

• Navigation to previous pages should go to the bottom.
• Add new option to follow logs.

Sounds good.

[jeefy]

Also it looks like you have a conflict in src/app/frontend/logs/template.html

When you make your additional changes, please resolve that before pushing. :)

Thanks!

[eloyekunle]

Implemented:

• Option to follow logs. This adds a new icon.
• Scroll to logs bottom when navigating to previous page.
• Scroll to logs top when navigation to next page.

[jeefy]

@eloyekunle Your latest changes broke some HTML formatting.

See https://travis-ci.org/kubernetes/dashboard/jobs/496191334#L297

You can test these CI checks locally by running npm run check (and others, see package.json for the other options)

After that quick formatting fix I'll give it one more look and lgtm it. :) Thanks!

[eloyekunle]

@jeefy Thanks, I've fixed the HTML formatting.

[jeefy]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eloyekunle, jeefy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jeefy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment