Switch chart engine from nvd3 to c3 #3590

eloyekunle · 2019-02-20T20:50:24Z

Node Detail:

Workload Status:

codecov · 2019-02-20T21:13:17Z

Codecov Report

Merging #3590 into master will increase coverage by 0.03%.
The diff coverage is 62.85%.

@@            Coverage Diff             @@
##           master    #3590      +/-   ##
==========================================
+ Coverage   46.91%   46.95%   +0.03%     
==========================================
  Files         171      171              
  Lines        7976     7972       -4     
  Branches       62       64       +2     
==========================================
+ Hits         3742     3743       +1     
+ Misses       4004     3999       -5     
  Partials      230      230

Impacted Files	Coverage Δ
...end/common/components/allocationchart/component.ts	`70.21% <62.85%> (+5.5%)`	⬆️
...p/backend/integration/metric/common/aggregation.go	`90.9% <0%> (+1.81%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ed73ca...5e196b1. Read the comment docs.

maciaszczykm · 2019-05-09T09:47:06Z

Hey, any updates?

eloyekunle · 2019-05-09T21:58:36Z

Hi @maciaszczykm, No updates yet, but by next week I'll be implementing the POC and the feedback from #3571 (comment) into this PR.

ajatprabha · 2019-05-28T10:45:30Z

src/app/frontend/common/components/allocationchart/component.ts

-    this.generateGraph_();
+  allocated = new Set();
+
+  ngAfterViewInit(): void {


Just curious, why can't we use ngOnInit() here?

@ajatprabha It wasn't displaying the chart with ngOnInit().

maciaszczykm · 2019-05-30T07:45:47Z

@eloyekunle Looks promising! Can you solve the conflicts?

floreks · 2019-05-30T08:40:39Z

@eloyekunle PR lgtm. Rebase please and we can merge.

maciaszczykm · 2019-05-30T13:55:10Z

You have to commit package-lock.json as you have also done some changes to the package.json. CI is failing due to that.

eloyekunle · 2019-05-30T14:37:58Z

@maciaszczykm Fixed now.

maciaszczykm · 2019-05-30T15:50:10Z

/lgtm
/approve

k8s-ci-robot · 2019-05-30T15:50:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eloyekunle, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 20, 2019

k8s-ci-robot requested review from cheld and ianlewis February 20, 2019 20:50

eloyekunle force-pushed the fix/d3-switch branch from 0d96265 to 8f834fc Compare May 9, 2019 21:18

eloyekunle changed the title ~~WIP - Switch chart engine from nvd3 to c3~~ WIP - Switch chart engine from nvd3 to d3 May 9, 2019

eloyekunle force-pushed the fix/d3-switch branch 2 times, most recently from fa4fa10 to bb0e44b Compare May 18, 2019 09:05

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 18, 2019

eloyekunle force-pushed the fix/d3-switch branch from b658d0b to 0c128b2 Compare May 19, 2019 11:20

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 19, 2019

eloyekunle force-pushed the fix/d3-switch branch 3 times, most recently from 8bbd387 to 5e8270e Compare May 19, 2019 12:00

eloyekunle closed this May 19, 2019

eloyekunle force-pushed the fix/d3-switch branch from 354dda9 to 2657e0b Compare May 19, 2019 15:43

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 19, 2019

eloyekunle reopened this May 19, 2019

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 19, 2019

eloyekunle changed the title ~~WIP - Switch chart engine from nvd3 to d3~~ WIP - Switch chart engine from nvd3 to c3 May 19, 2019

eloyekunle changed the title ~~WIP - Switch chart engine from nvd3 to c3~~ Switch chart engine from nvd3 to c3 May 19, 2019

ajatprabha approved these changes May 28, 2019

View reviewed changes

eloyekunle added 9 commits May 30, 2019 14:49

remove nvd3 and install c3

103c157

extend 'PieChartData' with 'key'

51bacd0

update colors

ce88dd8

added removed npm script

fd4f41e

add set property to track allocated

7e70cca

reset allocationchart html

0f4471b

reset allocationchart html

02f288f

change types/d3 package from range to specific version

3c9b53d

add chart type

012c13b

eloyekunle force-pushed the fix/d3-switch branch from e83b660 to 012c13b Compare May 30, 2019 13:50

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 30, 2019

fix duplicated packages in package.json

6fba7b4

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2019

eloyekunle force-pushed the fix/d3-switch branch from 63fbf3c to bd1efc8 Compare May 30, 2019 14:13

add package-lock.json

5e196b1

eloyekunle force-pushed the fix/d3-switch branch from bd1efc8 to 5e196b1 Compare May 30, 2019 14:29

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2019

k8s-ci-robot merged commit d222ace into kubernetes:master May 30, 2019

eloyekunle deleted the fix/d3-switch branch May 31, 2019 09:55

eloyekunle mentioned this pull request Sep 4, 2019

REQUEST: New membership for eloyekunle kubernetes/org#1157

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch chart engine from nvd3 to c3 #3590

Switch chart engine from nvd3 to c3 #3590

eloyekunle commented Feb 20, 2019 •

edited

Loading

codecov bot commented Feb 20, 2019 •

edited

Loading

maciaszczykm commented May 9, 2019

eloyekunle commented May 9, 2019 •

edited

Loading

ajatprabha May 28, 2019

eloyekunle May 30, 2019

maciaszczykm commented May 30, 2019

floreks commented May 30, 2019

maciaszczykm commented May 30, 2019

eloyekunle commented May 30, 2019

maciaszczykm commented May 30, 2019

k8s-ci-robot commented May 30, 2019

Switch chart engine from nvd3 to c3 #3590

Switch chart engine from nvd3 to c3 #3590

Conversation

eloyekunle commented Feb 20, 2019 • edited Loading

codecov bot commented Feb 20, 2019 • edited Loading

Codecov Report

maciaszczykm commented May 9, 2019

eloyekunle commented May 9, 2019 • edited Loading

ajatprabha May 28, 2019

Choose a reason for hiding this comment

eloyekunle May 30, 2019

Choose a reason for hiding this comment

maciaszczykm commented May 30, 2019

floreks commented May 30, 2019

maciaszczykm commented May 30, 2019

eloyekunle commented May 30, 2019

maciaszczykm commented May 30, 2019

k8s-ci-robot commented May 30, 2019

eloyekunle commented Feb 20, 2019 •

edited

Loading

codecov bot commented Feb 20, 2019 •

edited

Loading

eloyekunle commented May 9, 2019 •

edited

Loading