French translation #3770

feloy · 2019-04-28T13:50:14Z

codecov · 2019-04-28T13:57:54Z

Codecov Report

Merging #3770 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3770      +/-   ##
==========================================
+ Coverage    47.1%   47.13%   +0.02%     
==========================================
  Files         171      171              
  Lines        7971     7971              
  Branches       62       62              
==========================================
+ Hits         3755     3757       +2     
+ Misses       3976     3973       -3     
- Partials      240      241       +1

Impacted Files	Coverage Δ
...p/backend/integration/metric/common/aggregation.go	`89.09% <0%> (-1.82%)`	⬇️
src/app/backend/sync/secret.go	`73.26% <0%> (+2.97%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c18c3...d8e8f92. Read the comment docs.

maciaszczykm · 2019-05-02T16:21:05Z

Let us know when you would like to receive some feedback/review.

feloy · 2019-05-02T16:31:51Z

Feedbacks are welcome at this point. Thanks

Let us know when you would like to receive some feedback/review.

maciaszczykm · 2019-05-02T16:32:56Z

package.json

@@ -13,7 +13,7 @@
    "start:frontend:https": "node aio/scripts/version.js && ng serve --progress=false --aot --proxy-config aio/https-proxy.conf.json --ssl --host=0.0.0.0",
    "start:backend": "gulp serve --kubeconfig $npm_package_config_kubeconfig",
    "start:backend:https": "gulp serve --kubeconfig $npm_package_config_kubeconfig --autoGenerateCerts true --defaultCertDir $npm_package_config_kubeconfig_dir",
-    "start:prod": "npm run build && ./$npm_package_config_dashboard_binary_path --kubeconfig $npm_package_config_kubeconfig",
+    "start:prod": "npm run build && (cd $(dirname ./$npm_package_config_dashboard_binary_path) && ./$(basename $npm_package_config_dashboard_binary_path) --kubeconfig $npm_package_config_kubeconfig)",


cd looks ugly here. Can we avoid using it from npm scripts?

The purpose is to exec the process from its own directory, because the file ./locale_conf.json is referenced in the code.

I did not find the definition of the $npm_package_config_dashboard_binary_path variable, where is it defined?

It is defined in .npmrc.

maciaszczykm · 2019-05-02T16:34:12Z

src/app/frontend/chrome/notifications/template.html

@@ -15,11 +15,13 @@
 -->

 <div class="kd-notifications-container">
+  <span style="display: none"


We are trying to not use styles from templates. Why do you need it? What are these 3 lines doing?

The content is used some lines below, for the matTooltip translation. Unfortunately, there is a current limitation in the i18n angular code and it is not possible to use ICU ({VAR, select, ...}) in a i18n-matTooltip (or any i18n-*), so we need to create an invisible element for that.

It seems it is not possible either to use an ng-template element.

@ocombe do you have some advice on this problem?

So most likely the content of i18n-matTooltip is used by the directive directly and is not analyzed as template code, which is why the ICU doesn't work?
ng-template should work though

you can also use ng-container to create an invisible element

Here is the exact description of the problem: angular/angular#21615

And an explanation of the hack I'm using: http://chrisgriffing.com/coding/angular/2017/07/22/angular-i18n-icu-messages-attributes/

Unfortunately, that does not work with ng-container (the content is not invisible) or ng-template (the textContent is empty)

I've replaced the style="display: none" with an hidden attribute

maciaszczykm · 2019-05-02T16:34:29Z

src/app/frontend/common/components/card/template.html

@@ -35,10 +35,11 @@
         class="kd-card-actions kd-muted">
      <ng-content select="[actions]"></ng-content>
    </div>
-
+    <span style="display: none"
+          #translatedTooltip


feloy · 2019-05-04T14:43:10Z

I have finished the translation of the templates.

I will have to look at the MSG_ and figure out how to translate from the TS code (probably in another pull request).

maciaszczykm · 2019-05-09T08:16:56Z

Please rebase/merge master to fix the issues with the CI job. Sorry for the inconvenience.

jeefy · 2019-05-12T01:05:43Z

/lgtm

k8s-ci-robot · 2019-05-12T01:06:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy, jeefy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jeefy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

floreks · 2019-05-14T08:23:58Z

@jeefy @feloy @maciaszczykm

I don't want to revert it because overall it is really good work, but I'd address 2 things.

Remove usage of the hidden element as a workaround for tooltip message logic. Export the logic to a function and when angular will support translations from the ts/js code also we will use that.
Definitely remove cd ... logic from the package.json. We have to keep it simple. Building a translated version was already supported by our build scripts for prod.

feloy · 2019-05-14T09:18:53Z

I will work on this asap

feloy · 2019-05-14T18:20:32Z

@maciaszczykm I have proposed a patch on #3812

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 28, 2019

k8s-ci-robot requested review from bryk and cupofcat April 28, 2019 13:50

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 28, 2019

feloy force-pushed the feloy-i18n branch 2 times, most recently from cc6b26c to 92b4d66 Compare May 2, 2019 13:14

maciaszczykm reviewed May 2, 2019

View reviewed changes

feloy changed the title ~~WIP: French translation~~ French translation May 4, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2019

feloy changed the title ~~French translation~~ WIP: French translation May 4, 2019

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2019

feloy changed the title ~~WIP: French translation~~ French translation May 4, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2019

feloy added 9 commits May 9, 2019 18:27

Fix nested i18n tags

6127e3a

Generated i18n messages

5726dc1

WIP: French translation

c7b6f20

More translations

78f7d2a

Indent fr translation

f44edca

More translations

01f502b

All translations

60ad2c5

About page translation

90da2e3

Translate notifications panel

5776172

feloy added 17 commits May 9, 2019 18:28

Translate Quotas + Zerostate

0cafe4f

Translate resourcelists

27a1add

fix

5a4c304

Use hidden instead of style="display: none"

2b41c88

Translate create form

4f70b83

Fix translate help

b04215d

Translate create sub-dialogs

ebcaadd

Translate delete dialog

81cf364

Translate download dialog

b2496fd

Translate edit/trigger/scale dialogs

2d1914a

Translate login

37f503b

Translate Logs

54fc0c6

Translate Overview

55070a4

Translate resources informations

c4af322

Translate search result page

e08dc7e

Translate settings

1115fcd

Translate shell

d8e8f92

feloy force-pushed the feloy-i18n branch from 1a845ae to d8e8f92 Compare May 9, 2019 16:28

k8s-ci-robot assigned jeefy May 12, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2019

k8s-ci-robot merged commit e0420e4 into kubernetes:master May 12, 2019

feloy mentioned this pull request May 14, 2019

French translation fixes #3812

Merged

feloy mentioned this pull request May 30, 2019

Nested attribute translation in a translation not working. #3650

Closed

feloy mentioned this pull request Jan 6, 2021

REQUEST: New membership for feloy kubernetes/org#2404

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

French translation #3770

French translation #3770

feloy commented Apr 28, 2019 •

edited

Loading

codecov bot commented Apr 28, 2019 •

edited

Loading

maciaszczykm commented May 2, 2019

feloy commented May 2, 2019

maciaszczykm May 2, 2019

feloy May 2, 2019

floreks May 14, 2019

maciaszczykm May 2, 2019

feloy May 2, 2019

ocombe May 3, 2019 •

edited

Loading

feloy May 3, 2019 •

edited

Loading

maciaszczykm May 2, 2019

feloy commented May 4, 2019

maciaszczykm commented May 9, 2019

jeefy commented May 12, 2019

k8s-ci-robot commented May 12, 2019

floreks commented May 14, 2019 •

edited

Loading

feloy commented May 14, 2019

feloy commented May 14, 2019

French translation #3770

French translation #3770

Conversation

feloy commented Apr 28, 2019 • edited Loading

codecov bot commented Apr 28, 2019 • edited Loading

Codecov Report

maciaszczykm commented May 2, 2019

feloy commented May 2, 2019

maciaszczykm May 2, 2019

Choose a reason for hiding this comment

feloy May 2, 2019

Choose a reason for hiding this comment

floreks May 14, 2019

Choose a reason for hiding this comment

maciaszczykm May 2, 2019

Choose a reason for hiding this comment

feloy May 2, 2019

Choose a reason for hiding this comment

ocombe May 3, 2019 • edited Loading

Choose a reason for hiding this comment

feloy May 3, 2019 • edited Loading

Choose a reason for hiding this comment

maciaszczykm May 2, 2019

Choose a reason for hiding this comment

feloy commented May 4, 2019

maciaszczykm commented May 9, 2019

jeefy commented May 12, 2019

k8s-ci-robot commented May 12, 2019

floreks commented May 14, 2019 • edited Loading

feloy commented May 14, 2019

feloy commented May 14, 2019

feloy commented Apr 28, 2019 •

edited

Loading

codecov bot commented Apr 28, 2019 •

edited

Loading

ocombe May 3, 2019 •

edited

Loading

feloy May 3, 2019 •

edited

Loading

floreks commented May 14, 2019 •

edited

Loading