Remove redundant namespace filters

[eloyekunle]

In resourcechannels.go, REST queries already filtered by namespace should no longer be filtered by the filtering loop.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eloyekunle
To complete the pull request process, please assign cheld
You can assign the PR to them by writing /assign @cheld in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #3877 into master will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3877      +/-   ##
==========================================
+ Coverage   46.56%   46.94%   +0.37%     
==========================================
  Files         173      173              
  Lines        8066     8001      -65     
  Branches       59       59              
==========================================
  Hits         3756     3756              
+ Misses       4080     4015      -65     
  Partials      230      230

Impacted Files	Coverage Δ
...rc/app/backend/resource/common/resourcechannels.go	0% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89f56f0...acd3231. Read the comment docs.

[maciaszczykm]

Not sure about this anymore. Indeed ToRequestParam will filter with namespaces but it can be also set to all if there are more than 2 namespaces. Matches works in a different way, filtering using specific namespaces from NamespaceQuery.

@floreks Was this intended? Can we pick let's say 2 or 3 namespaces somewhere (not all of them)?

[eloyekunle]

You're right @maciaszczykm, ToRequestParam sets to ALL if there are more than 1 namespace. So the filters are indeed necessary.

[maciaszczykm]

Okay then, let's close it as it has some function.

/close

[k8s-ci-robot]

@maciaszczykm: Closed this PR.

In response to this:

Okay then, let's close it as it has some function.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.