-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from dep to go mod #3878
Migrate from dep to go mod #3878
Conversation
Great! Looking forward to merging this. Could you take a look at the errors in the CI? |
At least, before tests or building image that use vendor directory, we need to set
We can run almost tests on local. See https://github.com/kubernetes/dashboard/wiki/Getting-started#to-run-npm-commands-as-you-want . It's almost same as on travis. Please run test locally at first. |
The backend tests pass currently when I run it locally. This current broken build is from master, not the go modules migration. |
Rebase please to fix travis. |
7afc07f
to
5e58696
Compare
Codecov Report
@@ Coverage Diff @@
## master #3878 +/- ##
==========================================
- Coverage 46.57% 46.56% -0.02%
==========================================
Files 173 173
Lines 8066 8066
Branches 59 59
==========================================
- Hits 3757 3756 -1
- Misses 4079 4080 +1
Partials 230 230
Continue to review full report at Codecov.
|
I've rebased @floreks |
For now, I couldn't find why vendor directory [1] that were used by tests and build becomes unnecessary. But we need to clean up the use of vendor directory, if vendor is really unused. Could you clean up them? |
/approve Please solve conflicts and answer to @shu-mutou comment. |
@shu-mutou The |
5e58696
to
355738c
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eloyekunle, maciaszczykm, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since Go 1.11 there is a new way to structure packages, which don't require the project to live under
$GOPATH
, and provides version management.go mod
could superseeddep
, given it is builtin on the core tooling of the language and requires less dependencies to contribute.This commit follows the migration instructions to adopt
go mod
.