Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to client-go kubernetes-1.14.0 #3886

Merged
merged 2 commits into from
Jun 12, 2019

Conversation

eloyekunle
Copy link
Contributor

@eloyekunle eloyekunle commented Jun 8, 2019

Fixes #3870

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 8, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Jun 8, 2019
@eloyekunle eloyekunle changed the title WIP: Update to client-go kubernetes-1.14.0 Update to client-go kubernetes-1.14.0 Jun 9, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2019
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #3886 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3886      +/-   ##
==========================================
- Coverage   46.56%   46.54%   -0.03%     
==========================================
  Files         173      173              
  Lines        8066     8066              
  Branches       59       59              
==========================================
- Hits         3756     3754       -2     
- Misses       4080     4083       +3     
+ Partials      230      229       -1
Impacted Files Coverage Δ
src/app/backend/resource/job/pods.go 34.88% <0%> (ø) ⬆️
src/app/backend/sync/secret.go 70.29% <0%> (-2.98%) ⬇️
...p/backend/integration/metric/common/aggregation.go 90.9% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89f56f0...4df2d3d. Read the comment docs.

@maciaszczykm
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eloyekunle, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit c69bb48 into kubernetes:master Jun 12, 2019
@eloyekunle eloyekunle deleted the feat/update-client-go branch June 12, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to the new client-go
3 participants