Bump gts to 1.0.0 #4034

shu-mutou · 2019-07-09T09:43:30Z

Also, drop clang-format in favor of prettier.

codecov · 2019-07-10T00:09:33Z

Codecov Report

Merging #4034 into master will decrease coverage by 0.03%.
The diff coverage is 27.39%.

@@            Coverage Diff            @@
##           master   #4034      +/-   ##
=========================================
- Coverage   46.44%   46.4%   -0.04%     
=========================================
  Files         194     194              
  Lines        8919    8922       +3     
  Branches       81      83       +2     
=========================================
- Hits         4142    4140       -2     
- Misses       4523    4527       +4     
- Partials      254     255       +1

Impacted Files	Coverage Δ
src/app/frontend/common/errors/errors.ts	`45.09% <ø> (ø)`	⬆️
.../frontend/common/services/global/globalsettings.ts	`38.88% <0%> (-1.12%)`	⬇️
.../frontend/common/components/graphcard/component.ts	`70% <0%> (-3.69%)`	⬇️
...p/frontend/common/services/global/notifications.ts	`38.09% <0%> (ø)`	⬆️
...ntend/common/components/chips/chipdialog/dialog.ts	`62.5% <0%> (-8.93%)`	⬇️
.../app/frontend/common/services/resource/resource.ts	`37.83% <0%> (-1.06%)`	⬇️
.../app/frontend/common/services/global/authorizer.ts	`53.33% <0%> (ø)`	⬆️
.../app/frontend/common/services/resource/endpoint.ts	`80.48% <0%> (-2.02%)`	⬇️
src/app/frontend/common/pipes/module.ts	`100% <100%> (ø)`	⬆️
...p/frontend/common/components/property/component.ts	`100% <100%> (ø)`	⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74fb80a...05ffef5. Read the comment docs.

shu-mutou · 2019-07-10T03:59:25Z

gts does not seems to have way to disable prettier. To ignore all ts files, .prettierignore file was not effective. Therefore if we keep to using and updating gts, we need to accept prettier's formatting.

293 files are changed by default settings.
235 files changed by custom settings.

@maciaszczykm Please let me know which options would help your readablity.

maciaszczykm · 2019-07-10T06:56:08Z

src/app/frontend/common/components/resourcelist/deployment/component.ts

+      this.icon.timelapse,
+      'kd-muted',
+      this.isInPendingState
+    );


Styling is not so bad but there are a few things I don't like. For me prettier is using too much of new lines like in the example above. Can we limit it somehow?

I think so too. We can set maximum length for each line to suppress adding new line, but pettier does not have option such as allowing to enumerate arguments on the second and subsequent lines.
I tried to set options for prettier to format closer as current code in subsequent commit. Please check it. 😉

maciaszczykm · 2019-07-11T07:51:55Z

Looks better already.

/approve

@floreks WDYT?

shu-mutou · 2019-07-18T06:49:43Z

/hold
This PR tends to conflict due to other mergings and would cause lots of conflict in other PRs. Also, in order to create this PR, it is necessary to recreate manually instead of rebasing. Please let me know when it is time to merge this PR.
If the time will come, I will recreate this PR ASAP.

maciaszczykm · 2019-07-18T07:00:09Z

I am fine with moving it forward, @floreks @jeefy WDYT?

floreks · 2019-07-18T14:21:36Z

I think we can do this after we release beta2. Maybe today.

maciaszczykm · 2019-07-18T16:19:29Z

@shu-mutou It is the right time to rebase. I can LGTM then.

Fixed typescript format due to introducing `prettier`. Also, drop `clang-format` in favor of `prettier`.

shu-mutou · 2019-07-19T04:48:23Z

/hold cancel

shu-mutou · 2019-07-19T05:13:21Z

If conflicts occur in your PR due to this PR, please handle your PR before rebasing as follow:

introduce changes as same as this PR other than ts files.

.clang-format
.prettierrc.yaml
aio/scripts/conf.sh
aio/scripts/version.js
package.json
tslint.json

remove package-lock.js
run npm i
run npm fix:frontend
then rebase your PR to master

maciaszczykm · 2019-07-19T07:07:51Z

/lgtm
/approve

k8s-ci-robot · 2019-07-19T07:08:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Update node-gyp to the latest version 🚀 (#4010) * chore(package): update node-gyp to version 5.0.2 * chore(package): update lockfile package-lock.json * Update angular2 to the latest version 🚀 (#4007) * fix(package): update @angular/material to version 8.0.2 * fix(package): update @angular/cdk to version 8.0.2 * chore(package): update lockfile package-lock.json * Update @angular/cli to the latest version 🚀 (#4005) * chore(package): update @angular/cli to version 8.1.0 * chore(package): update lockfile package-lock.json * Update del to the latest version 🚀 (#4004) * chore(package): update del to version 5.0.0 * chore(package): update lockfile package-lock.json * Update lint-staged to the latest version 🚀 (#4011) * chore(package): update lint-staged to version 9.0.2 * chore(package): update lockfile package-lock.json * Update @types/node to the latest version 🚀 (#4016) * chore(package): update @types/node to version 12.0.11 * chore(package): update lockfile package-lock.json * Add xliffmerge to update translated files (#3991) To apply differences of `i18n/messages.xlf` into treanslated files, i.e. `messages.[locale].xlf` like `messages.fr.xlf` and `messages.ja.xlf`, introduce `xliffmerge` and run it after `ng xi18n`. * Add workload statuses to workloads view (#3989) * Reorganize `docs/` (#4009) To migrate wiki contents into `docs/`, prepare directory and file structures. Contents of each pages would be added as latest in subsequent PRs. * CRD Support - Backend (#3843) * Installed k8s.io/apiextensions-apiserver * implement crd list - GetCustomResourceDefinitionList * add method to fetch API extensions client to client manager * implement verber for custom resource definitions * update fakeClient with new client manager methods * add tests for APIExtensionsClient * add events source file * add events test source file * implement objects list endpoint * replace '.Raw' with '.Into' in objects list * implement getCustomResourceObjectDetail * replace kdErrors with errors * fix conflicts * implement get crd detail * implement get events for custom resource object * add version to CustomResourceDefinition type * add (failing) test for detail fetch * add tests for cr objects events * remove unused import * update dependencies * rename customresourcedefinition to crd * removed vendor dir * update deps, remove object tests * order imports * Fix the wording on settings page (#4020) * Fix the wording on settings page * Add messages.new.xlf to .gitignore * Update deploy files (#4019) * Update deploy files * Update image versions * Update build pipeline * Cleanup travis * Restore build before push * Release v2.0.0-beta1 (#4018) * add scraper to recommended. remove amd64 tag (we have manifests now) * Update version to v2.0.0-beta1 * Regenerate package-lock.json * Fix release stage * Fix deploy files * Update c3 to the latest version 🚀 (#4025) * fix(package): update c3 to version 0.7.2 * chore(package): update lockfile package-lock.json * Update lint-staged to the latest version 🚀 (#4026) * chore(package): update lint-staged to version 9.1.0 * chore(package): update lockfile package-lock.json * Update @types/node to the latest version 🚀 (#4031) * chore(package): update @types/node to version 12.6.0 * chore(package): update lockfile package-lock.json * Update documentations for development guide (#4012) * Getting started * Code conventions * Text conventions * Internationalization * Update lodash to the latest version 🚀 (#4035) * chore(package): update lodash to version 4.17.12 * chore(package): update lockfile package-lock.json * Update @types/lodash to the latest version 🚀 (#4032) * chore(package): update @types/lodash to version 4.14.136 * chore(package): update lockfile package-lock.json * Update @types/node to the latest version 🚀 (#4036) * chore(package): update @types/node to version 12.6.2 * chore(package): update lockfile package-lock.json * Update xterm to the latest version 🚀 (#4041) * fix(package): update xterm to version 3.14.5 * chore(package): update lockfile package-lock.json * Update @angular-devkit/build-angular to the latest version 🚀 (#4040) * chore(package): update @angular-devkit/build-angular to version 0.801.1 * chore(package): update lockfile package-lock.json * Fix shell and npm dep vulnerability (#4045) * Fix and refactor workload statuses (#4047) * Fix and refactor workload statuses * Fix tests * Update dependencies to support Kubernetes v15.0.0 (#4048) * Update client-go to v12.0.0 Update api and apimachinery to support Kubernetes v15.0.0 * Remove apimachinery override * Remove debug leftover * Remove rf232 from maintainers (#4050) I'm not involved in dashboard anymore, and haven't been for a long time. * Fix skip button on login view (#4051) * Redesign chips (#4049) * Redesign chips * Format the code * Migrate some of the docs (#4052) * Add architecture doc Move images to the new dir * Add deps managment doc * Update some of the docs * Update link to the docs * Add links to the wiki * Update 1.6.x-and-below.md * Update 1.7.x-and-above.md * Update architecture.md * Update karma to the latest version 🚀 (#4057) * chore(package): update karma to version 4.2.0 * chore(package): update lockfile package-lock.json * Plugin controller to manage plugin source from dashboard backend (#4017) * add CRD for Plugin kind * add api types and test plugin yaml file * prepare for codegen * generate code from update-codegen * add pluginclientset.Interface to clientManager and PluginClient method to ClientManager interface * map v1alpha1.PluginList to plugin.PluginList * serve plugin code from configmap data based on spec from Plugin CRD * move plugin specific routes to handler.go in plugin package * move plugin-crd.yml to test-resources * add comments to files * add content type header and remove file extension properly * add tests for plugin package * fix license header errors * Update angular2 to the latest version 🚀 (#4061) * fix(package): update @angular/material to version 8.1.0 * fix(package): update @angular/cdk to version 8.1.0 * chore(package): update lockfile package-lock.json * Migrate docs for `Labels` (#4062) * Fix ingress endpoint resolution (#4033) * init Chinese translation (#4063) * add Simplified Chinese translation * Update package.json * Update angular2 to the latest version 🚀 (#4065) * fix(package): update @angular/material to version 8.1.1 * fix(package): update @angular/cdk to version 8.1.1 * chore(package): update lockfile package-lock.json * Update @types/c3 to the latest version 🚀 (#4066) * fix(package): update @types/c3 to version 0.7.1 * chore(package): update lockfile package-lock.json * Update @types/node to the latest version 🚀 (#4067) * chore(package): update @types/node to version 12.6.6 * chore(package): update lockfile package-lock.json * Update node-gyp to the latest version 🚀 (#4068) * chore(package): update node-gyp to version 5.0.3 * chore(package): update lockfile package-lock.json * Update @angular/cli to the latest version 🚀 (#4076) * chore(package): update @angular/cli to version 8.1.2 * chore(package): update lockfile package-lock.json * Correct typo in markdown formatting (#4074) * Update @types/node to the latest version 🚀 (#4072) * chore(package): update @types/node to version 12.6.7 * chore(package): update lockfile package-lock.json * Restore history service and add auto-refresh (#4080) * Restore history service, add simple auto-refresh, fix view change after delete * Revert lost translations * Update logic * Support dashboard-metrics-scraper on development container (#4046) Deploy `dashboard-metrics-scraper` on `kind` cluster. Then pass `--sidecar-host` to dashboard via `npm` or `gulp`. Also, cleanup handlings of `kubeconfig` for `kind`. * impersonation support for the dashboard (#4082) * Added user impersonation and username to ui * groups working * Added unit tests, extras for impersonation * added docs * fixed formatting to be consistent * updates per pr review * ran npm frontend:fix per travis ci * Reenable namespace change dialog (#4081) * Add namespace change dialog * Apply changes * Make deployment files consistent (#4083) * Bump version to v2.0.0-beta2 (#4084) * add tmp-volume to metrics-scraper (#4087) * add tmp-volume to metrics-scraper * the test resource has slightly different indenting * more indenting differences * Bump gts to 1.0.0 (#4034) Fixed typescript format due to introducing `prettier`. Also, drop `clang-format` in favor of `prettier`. * Update husky to the latest version 🚀 (#4089) * chore(package): update husky to version 3.0.1 * chore(package): update lockfile package-lock.json * Update karma-coverage-istanbul-reporter to the latest version 🚀 (#4099) * chore(package): update karma-coverage-istanbul-reporter to version 2.0.6 * chore(package): update lockfile package-lock.json * make resource information card title consistent (#4103) * [bugfix] Change golang tag (#4106) * [bugfix] Change golang tag `golang:1.12` can't install `openjdk-8-jre`,it's apt source only have 'openjdk-11' so we need change golang's tag for `openjdk-8`. I chenge it to `golang:1.10`, then build mirror successfully in my machine. * Update Dockerfile Restore golang tag, delete openjdk-8-jre dependency * Update semver to the latest version 🚀 (#4107) * chore(package): update semver to version 6.3.0 * chore(package): update lockfile package-lock.json * Update errors.ts (#4109) Fixed grammatical mistake in error msg * Update karma-coverage-istanbul-reporter to the latest version 🚀 (#4111) * chore(package): update karma-coverage-istanbul-reporter to version 2.1.0 * chore(package): update lockfile package-lock.json * Re-install git in development container and suppress download from `golangci-lint` (#4113) husky-3.0 requires git>=2.13.2, but golang:1.12 container image based on devian 9 (stretch) does not satisfy the requirement. So re-install specified version of git from source code. Also, added setting `modules-download-mode: readonly` in `.golangci.yml` to suppress download in running `golangci-lint`. * use KUBECONFIG or default to npmrc (#3593) * Update lint-staged to the latest version 🚀 (#4114) * chore(package): update lint-staged to version 9.2.1 * chore(package): update lockfile package-lock.json * Remove auth cookies when forced logged out (#4119) * Remove auth cookies when forced logged out * Regenerate lockfile * Fix GID on development container (#4120) Run `groupadd` in `gosu-command.sh` when group that has `$LOCAL_GID` does not exist. * Fix chips styling (#4118) * Fix text input (#4122) * Fix exec (#4124) * Fix exec * Remove debug logs * Update @types/jasmine to the latest version 🚀 (#4131) * chore(package): update @types/jasmine to version 3.3.16 * chore(package): update lockfile package-lock.json * Update c3 to the latest version 🚀 (#4133) * fix(package): update c3 to version 0.7.3 * chore(package): update lockfile package-lock.json * Update husky to the latest version 🚀 (#4135) * chore(package): update husky to version 3.0.2 * chore(package): update lockfile package-lock.json * Update @angular/cli to the latest version 🚀 (#4136) * chore(package): update @angular/cli to version 8.1.3 * chore(package): update lockfile package-lock.json * Update angular2 to the latest version 🚀 (#4140) * fix(package): update @angular/material to version 8.1.2 * fix(package): update @angular/cdk to version 8.1.2 * chore(package): update lockfile package-lock.json * Update gts to the latest version 🚀 (#4144) * chore(package): update gts to version 1.1.0 * chore(package): update lockfile package-lock.json * add metrics-provider's no check metrics option (#4143) * Update @angular/cli to the latest version 🚀 (#4148) * chore(package): update @angular/cli to version 8.2.0 * chore(package): update lockfile package-lock.json * CRD Support - Frontend (#4030) * add crd to sidenav * add crd routing * add crd module * fix headers * add divider to sidebar * implement crd list * add crd detail interface * add more columns to table * update crd detail fetch * show crd conditions in crd detail page * added types for crd objects * implement crd objects list * add crd information card and accepted names * add versions table to crd detail * update version table * lint files * add actionbar buttons to crd detail * add status icon * lint fix * update crd object route * wip * update crdobject api * crd object extending resourcelistbase * update objects list * extend verber to support raw crd objects * enable action bar buttons on object detail page * implement raw data display for CRD object * fix failing test * add code section to crdobject * add syntax highlighting * fix issue in i18n file * fix html formatting * Add context menus in list views for cluster resources (#4130) * Migrate e2e tests to Cypress (#4002) * installed cypress and added sample test * readd aot compilation * Prepare for v2.0.0-beta3 (#4152)

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 9, 2019

k8s-ci-robot requested review from konryd and maciaszczykm July 9, 2019 09:43

shu-mutou changed the title ~~Bump gts to 1.0.0~~ [WIP] Bump gts to 1.0.0 Jul 9, 2019

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2019

shu-mutou force-pushed the gts-1.0.0 branch from cb2fd95 to 50eaf66 Compare July 10, 2019 00:09

shu-mutou force-pushed the gts-1.0.0 branch 2 times, most recently from 0369fac to 278bfee Compare July 10, 2019 03:57

shu-mutou mentioned this pull request Jul 10, 2019

Fix ts errors #3795

Merged

2 tasks

shu-mutou changed the title ~~[WIP] Bump gts to 1.0.0~~ Bump gts to 1.0.0 Jul 10, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2019

maciaszczykm reviewed Jul 10, 2019

View reviewed changes

shu-mutou force-pushed the gts-1.0.0 branch 2 times, most recently from f878339 to 2e41156 Compare July 11, 2019 03:54

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2019

shu-mutou force-pushed the gts-1.0.0 branch from 2e41156 to b79955a Compare July 12, 2019 08:21

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2019

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2019

Bump gts to 1.0.0

05ffef5

Fixed typescript format due to introducing `prettier`. Also, drop `clang-format` in favor of `prettier`.

shu-mutou force-pushed the gts-1.0.0 branch from b79955a to 05ffef5 Compare July 19, 2019 04:44

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2019

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2019

k8s-ci-robot assigned maciaszczykm Jul 19, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2019

k8s-ci-robot merged commit 7b199ee into kubernetes:master Jul 19, 2019

shu-mutou deleted the gts-1.0.0 branch July 19, 2019 08:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump gts to 1.0.0 #4034

Bump gts to 1.0.0 #4034

shu-mutou commented Jul 9, 2019 •

edited

Loading

codecov bot commented Jul 10, 2019 •

edited

Loading

shu-mutou commented Jul 10, 2019 •

edited

Loading

maciaszczykm Jul 10, 2019

shu-mutou Jul 11, 2019

maciaszczykm commented Jul 11, 2019

shu-mutou commented Jul 18, 2019

maciaszczykm commented Jul 18, 2019

floreks commented Jul 18, 2019

maciaszczykm commented Jul 18, 2019

shu-mutou commented Jul 19, 2019

shu-mutou commented Jul 19, 2019 •

edited

Loading

maciaszczykm commented Jul 19, 2019

k8s-ci-robot commented Jul 19, 2019

Bump gts to 1.0.0 #4034

Bump gts to 1.0.0 #4034

Conversation

shu-mutou commented Jul 9, 2019 • edited Loading

codecov bot commented Jul 10, 2019 • edited Loading

Codecov Report

shu-mutou commented Jul 10, 2019 • edited Loading

maciaszczykm Jul 10, 2019

Choose a reason for hiding this comment

shu-mutou Jul 11, 2019

Choose a reason for hiding this comment

maciaszczykm commented Jul 11, 2019

shu-mutou commented Jul 18, 2019

maciaszczykm commented Jul 18, 2019

floreks commented Jul 18, 2019

maciaszczykm commented Jul 18, 2019

shu-mutou commented Jul 19, 2019

shu-mutou commented Jul 19, 2019 • edited Loading

maciaszczykm commented Jul 19, 2019

k8s-ci-robot commented Jul 19, 2019

shu-mutou commented Jul 9, 2019 •

edited

Loading

codecov bot commented Jul 10, 2019 •

edited

Loading

shu-mutou commented Jul 10, 2019 •

edited

Loading

shu-mutou commented Jul 19, 2019 •

edited

Loading