Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'Scale' subresource for CRDs #4195

Merged
merged 7 commits into from
Aug 29, 2019

Conversation

eloyekunle
Copy link
Contributor

Backend implementation via k8s.io/client-go/scale currently unable to work with cluster-scoped resources. Tracking issue: kubernetes/kubernetes#81380

Closes #4167

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 13, 2019
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b565ea3). Click here to learn what that means.
The diff coverage is 25.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4195   +/-   ##
=========================================
  Coverage          ?   45.95%           
=========================================
  Files             ?      198           
  Lines             ?     9298           
  Branches          ?      105           
=========================================
  Hits              ?     4273           
  Misses            ?     4765           
  Partials          ?      260
Impacted Files Coverage Δ
...ackend/resource/customresourcedefinition/detail.go 0% <0%> (ø)
...ckend/resource/customresourcedefinition/objects.go 0% <0%> (ø)
src/app/backend/api/types.go 38.88% <0%> (ø)
src/app/backend/handler/apihandler.go 27.24% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b565ea3...1f84d7c. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 14, 2019
@eloyekunle eloyekunle changed the title WIP: Support 'Scale' subresource for CRDs Support 'Scale' subresource for CRDs Aug 14, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2019
@eloyekunle
Copy link
Contributor Author

This is ready for review, PTAL.

/assign @jeefy @maciaszczykm @floreks

@maciaszczykm
Copy link
Member

Please rebase.

@eloyekunle
Copy link
Contributor Author

Rebased.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2019
@maciaszczykm
Copy link
Member

Tested locally.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eloyekunle, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 24b04c5 into kubernetes:master Aug 29, 2019
@eloyekunle eloyekunle deleted the feat/crd-scale branch August 29, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support 'Scale' subresource for CRDs
5 participants