-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm-chart): support readinessprobe #7899
Conversation
Welcome @maxime1907! |
c1c07a5
to
9aba785
Compare
Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
9aba785
to
535a0bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #7899 +/- ##
==========================================
- Coverage 42.19% 42.18% -0.01%
==========================================
Files 218 218
Lines 12099 12099
Branches 179 179
==========================================
- Hits 5105 5104 -1
- Misses 6709 6710 +1
Partials 285 285 |
@desaintmartin Could you take a look this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks for the contribution!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: desaintmartin, maxime1907 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.