-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm] Add tpl function to config and ingress for supporting umbrella charts #8225
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jkroepke The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! Could you bump chart version? From experience, this is indeed beneficial, but can be hard to properly setup. |
… charts Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
ff49eb5
to
ea99266
Compare
Rebased and bumped |
|
How we can proceed here? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8225 +/- ##
=======================================
Coverage 42.23% 42.23%
=======================================
Files 219 219
Lines 12184 12184
Branches 179 179
=======================================
Hits 5146 5146
Misses 6740 6740
Partials 298 298 |
Merged from main (to fix CI issues) |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Having the tpl function in place here is a real benefit, since a central helm value can be used for ingress hostname across all subscharts.
Various other helm charts like kube-prometheus-stack, grafana, blackbox_exporter, grafana loki are supporting this style, too.