Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: Fix web module image #8738

Merged
merged 4 commits into from
Mar 4, 2024
Merged

wip: Fix web module image #8738

merged 4 commits into from
Mar 4, 2024

Conversation

maciaszczykm
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2024
@maciaszczykm maciaszczykm added the kind/bug Categorizes issue or PR as related to a bug. label Mar 4, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited
Loading

Codecov Report

Merging #8738 (b13f2a7) into master (94dd3cb) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8738   +/-   ##
=======================================
  Coverage   35.77%   35.77%           
=======================================
  Files         252      252           
  Lines       10708    10708           
  Branches      157      157           
=======================================
  Hits         3831     3831           
- Misses       6626     6664   +38     
+ Partials      251      213   -38

@maciaszczykm maciaszczykm merged commit a75c384 into master Mar 4, 2024
5 of 11 checks passed
@maciaszczykm maciaszczykm deleted the fix-web branch March 4, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks Awaiting requested review from floreks

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciaszczykm @k8s-ci-robot