Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): improve pod container status logic and add simplified status to pod details #8913

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

floreks
Copy link
Member

@floreks floreks commented Apr 15, 2024

  • Add new Failed state to simplified pod container state based on exit code.
  • Add same simplified state to pod details structure
  • Improve gql schema generation to use enum for container state

@floreks floreks added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 15, 2024
@floreks floreks self-assigned this Apr 15, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Merging #8913 (7fca596) into master (848c714) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8913      +/-   ##
==========================================
- Coverage   37.20%   37.19%   -0.02%     
==========================================
  Files         255      255              
  Lines       11149    11153       +4     
  Branches      157      158       +1     
==========================================
  Hits         4148     4148              
- Misses       6752     6793      +41     
+ Partials      249      212      -37     

@floreks floreks added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 577dd58 into master Apr 15, 2024
15 checks passed
@floreks floreks deleted the pod/container-state branch April 15, 2024 13:52
kireque pushed a commit to kireque/home-ops that referenced this pull request Apr 16, 2024
)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [kubernetes-dashboard](https://github.com/kubernetes/dashboard) |
patch | `7.3.1` -> `7.3.2` |

---

### Release Notes

<details>
<summary>kubernetes/dashboard (kubernetes-dashboard)</summary>

###
[`v7.3.2`](https://github.com/kubernetes/dashboard/releases/tag/kubernetes-dashboard-7.3.2)

[Compare
Source](https://github.com/kubernetes/dashboard/compare/kubernetes-dashboard-7.3.1...kubernetes-dashboard-7.3.2)

#### What's Changed

- chore(deps-dev): bump
[@&#8203;graphql-mesh/runtime](https://github.com/graphql-mesh/runtime)
from 0.98.7 to 0.98.8 in /modules/web by
[@&#8203;dependabot](https://github.com/dependabot) in
[kubernetes/dashboard#8893
- chore(deps): bump codecov/codecov-action from 4.2.0 to 4.3.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[kubernetes/dashboard#8897
- chore(deps-dev): bump
[@&#8203;types/node](https://github.com/types/node) from 20.12.5 to
20.12.7 in /modules/web by
[@&#8203;dependabot](https://github.com/dependabot) in
[kubernetes/dashboard#8899
- chore(deps-dev): bump
[@&#8203;graphql-mesh/cli](https://github.com/graphql-mesh/cli) from
0.89.8 to 0.89.9 in /modules/web by
[@&#8203;dependabot](https://github.com/dependabot) in
[kubernetes/dashboard#8889
- chore(deps-dev): bump
[@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)
from 7.5.0 to 7.6.0 in /modules/web by
[@&#8203;dependabot](https://github.com/dependabot) in
[kubernetes/dashboard#8892
- chore(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)
from 7.5.0 to 7.6.0 in /modules/web by
[@&#8203;dependabot](https://github.com/dependabot) in
[kubernetes/dashboard#8890
- chore(deps-dev): bump tar from 6.2.1 to 7.0.0 in /modules/web by
[@&#8203;dependabot](https://github.com/dependabot) in
[kubernetes/dashboard#8904
- chore(deps-dev): bump sass from 1.74.1 to 1.75.0 in /modules/web by
[@&#8203;dependabot](https://github.com/dependabot) in
[kubernetes/dashboard#8905
- chore(deps-dev): bump webpack-bundle-analyzer from 4.10.1 to 4.10.2 in
/modules/web by [@&#8203;dependabot](https://github.com/dependabot) in
[kubernetes/dashboard#8907
- chore(deps-dev): bump cypress from 13.7.2 to 13.7.3 in /modules/web by
[@&#8203;dependabot](https://github.com/dependabot) in
[kubernetes/dashboard#8908
- chore(deps-dev): bump sass-loader from 14.1.1 to 14.2.0 in
/modules/web by [@&#8203;dependabot](https://github.com/dependabot) in
[kubernetes/dashboard#8906
- chore(deps): bump ace-builds from 1.32.9 to 1.33.0 in /modules/web by
[@&#8203;dependabot](https://github.com/dependabot) in
[kubernetes/dashboard#8911
- chore(deps-dev): bump tar from 7.0.0 to 7.0.1 in /modules/web by
[@&#8203;dependabot](https://github.com/dependabot) in
[kubernetes/dashboard#8912

##### API

- feat(api): improve pod container status logic and add simplified
status to pod details by [@&#8203;floreks](https://github.com/floreks)
in
[kubernetes/dashboard#8913

##### Helm Chart

- chore(chart): bump chart to 7.3.2 and api to 1.5.0 by
[@&#8203;floreks](https://github.com/floreks) in
[kubernetes/dashboard#8914

**Full Changelog**:
kubernetes/dashboard@kubernetes-dashboard-7.3.1...kubernetes-dashboard-7.3.2

#### Installation

```sh
helm repo add kubernetes-dashboard https://kubernetes.github.io/dashboard/
helm upgrade --install kubernetes-dashboard kubernetes-dashboard/kubernetes-dashboard --create-namespace --namespace kubernetes-dashboard
```

#### Compatibility

| Kubernetes version | 1.27 | 1.28 | 1.29 |
|--------------------|-----|-----|-----|
| Compatibility            | ?   |   ?   |   ✓    |

-   `✓` Fully supported version range.
- `?` Due to breaking changes between Kubernetes API versions, some
features might not work correctly in the Dashboard.

#### Images

    docker.io/kubernetesui/dashboard-api:1.5.0
    docker.io/kubernetesui/dashboard-auth:1.1.3
    docker.io/kubernetesui/dashboard-metrics-scraper:1.1.1
    docker.io/kubernetesui/dashboard-web:1.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yOTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI5Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants