Make Kubernetes aware of the LoadBalancer behaviour

[Sh4d1]

Enhancement Description

• Make Kubernetes aware of the LoadBalancer behaviour
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1860-kube-proxy-IP-node-binding
• Primary contact (assignee): @Sh4d1
• Responsible SIGs: sig-network, sig-cloudprovider
• Enhancement target (which target equals to which milestone):

  • Alpha release target (1.29)

    • Make Kubernetes aware of the LoadBalancer behaviour kubernetes#119937
    • follow up on " Merged Make Kubernetes aware of the LoadBalancer behaviour" kubernetes#120068

  • Beta release target (1.30)

    • Promote LoadBalancerIPMode to Beta kubernetes#123418

  • Stable release target (x.y)

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

[Sh4d1]

/sig network

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[Sh4d1]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @Sh4d1

1.20 Enhancements Lead here. This KEP still seems to be a draft (it's provisional) but wanted to check-in to see if you thought this would be graduating alpha in 1.20?

Enhancements Freeze is October 6th and by that time we require:

The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria
The KEP must have an issue in the milestone

Best,
Kirsten

[kikisdeliveryservice]

Note: this provisional kep was implemented without having a compliant kep or indicating to the enhancements team that it would be in the 1.20 milestone.

[jeremyrickard]

Hey @Sh4d1 and @thockin,

👋 1.20 release lead here. We're really close to code freeze at this point (Thursday) and it seems like this KEP fell through the cracks and the process.

Based on this comment in the PR above: kubernetes/kubernetes#92312 (comment) can we not land this in 1.20 and instead target 1.21?

There are few things w/ the KEP that really should be address:

• It's provisional still
• There is no test plan
• There is no graduation criteria

Looks like there is also a PR to update the KEP https://github.com/kubernetes/enhancements/pull/2134/files that addresses this stuff, however it also marks it as implemented and targets 1.21. Typically, we set to implemented only after the release.

Can we circle back around on this and agree that we should try to land this in 1.21 at this point? We've already got a lot of content for the release so far (sig-docs has their work cut out for themselves!!!), we're two days out from code freeze, we have these disconnects mentioned above?

[Sh4d1]

@jeremyrickard just opened kubernetes/kubernetes#96454 to revert it, sorry again!
And updated #2134 to set it as implentable instead of implemented

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Sh4d1]

/reopen

[k8s-ci-robot]

@Sh4d1: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[salehsedghpour]

Hey again @RyanAoh and @thockin 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• Promote LoadBalancerIPMode to Beta kubernetes#123418

With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[rikatz]

@salehsedghpour @aojea is reviewing it :)

as neither me or @RyanAoh have access to edit the issue, we need someone with write access to do it and add thePR :/

thanks

[rikatz]

@salehsedghpour 👋
The PR is merged on k/k, kubernetes/website#45219 is waiting to be merged on k/docs.

I think we can move out of "Risk for Code freeze", right?

Thanks!

[salehsedghpour]

@rikatz with kubernetes/kubernetes#123418 being merged, this can now be marked as tracked for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[thockin]

This went beta in 30. GA in 31? Or wait for 32?

[rikatz]

I am not sure if I will be able to work through it to GA for 31

@danwinship and @aojea I've seen some movement of this and KinD cloud provider, any feedback there?

I will get some feedback internally as well

@RyanAoh do you wanna take over back for .30?

[aojea]

@danwinship and @aojea I've seen some movement of this and KinD cloud provider, any feedback there?

@danwinship is going to add the feature to e2e tests and we are going to test it in the CI with cloud provider kind, that now uses envoy ... I think this testing can give us good confidence ... but maybe waiting one release in beta is not. bad option

[rikatz]

Agreed. Tim, let's target for .32 then :)

[thockin]

ACK. Flagged to re-evaluate in 32

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[thockin]

@rikatz @RyanAoh - how does this look for 1.32?

[RyanAoh]

OK, I would promote it to GA in 1.32.

[rikatz]

Thanks @RyanAoh !

I will watch it, let me know if you need something from me!

[aojea]

Dan and I added way more coverage with cloud-provider-kind so I think we are good to go

[thockin]

Can I get a quick update? Is someone on the hook for a PR to promote this?

[rikatz]

I am not, @RyanAoh is in charge of this one :)

[RyanAoh]

@thockin I'm on it and I'll submit the PR(codes, docs and the PRR) this weekend.