Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Plugin mechanism for kubectl #579

Closed
juanvallejo opened this issue Jun 26, 2018 · 23 comments
Closed

Updated Plugin mechanism for kubectl #579

juanvallejo opened this issue Jun 26, 2018 · 23 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@juanvallejo
Copy link
Contributor

juanvallejo commented Jun 26, 2018

Feature Description

  • One-line feature description (can be used as a release note): kubectl should support extensions adding new commands as well as overriding specific subcommands (at any depth).
  • Primary contact (assignee): juanvallejo, soltysh
  • Responsible SIGs: sig-cli
  • Design proposal link (community repo): Add kubectl plugin mechanism KEP community#2437
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: pwittrock, soltysh
  • Approver (likely from SIG/area to which feature belongs): pwittrock, soltysh
  • Feature target (which target equals to which milestone): 1.12
    • Alpha release target (x.y) 1.12
    • Beta release target (x.y) 1.13
    • Stable release target (x.y) 1.14
@juanvallejo
Copy link
Contributor Author

/sig cli

cc @soltysh

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Jun 26, 2018
@soltysh soltysh added this to the v1.12 milestone Jul 5, 2018
@soltysh soltysh added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 5, 2018
@justaugustus
Copy link
Member

@juanvallejo @soltysh --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@justaugustus
Copy link
Member

/stage beta

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Jul 18, 2018
@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 29, 2018
@justaugustus
Copy link
Member

/remove-stage beta
/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Aug 4, 2018
@zparnold
Copy link
Member

Hey there! @juanvallejo I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@juanvallejo
Copy link
Contributor Author

@zparnold Sure, will open PR updating cli docs against 1.12

@zparnold
Copy link
Member

zparnold commented Aug 25, 2018 via email

@soltysh
Copy link
Contributor

soltysh commented Oct 5, 2018

@kacole2 this will be promoted to beta in 1.13, I haven't seen it in the tracking spreadsheet.
/milestone v1.13

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.12, v1.13 Oct 5, 2018
@kacole2 kacole2 added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Oct 5, 2018
@kacole2
Copy link

kacole2 commented Oct 5, 2018

@soltysh this has been added to the tracking sheet. thanks!

@spiffxp
Copy link
Member

spiffxp commented Oct 17, 2018

@soltysh what work remains to be done to promote this to beta? are there issues or PR's we could link to track?

@juanvallejo
Copy link
Contributor Author

@spiffxp

what work remains to be done to promote this to beta? are there issues or PR's we could link to track?

All of the outstanding work has been completed. We'll just need to update docs and tags labeling this feature as beta

@juanvallejo
Copy link
Contributor Author

Docs update: kubernetes/website#10796

@claurence
Copy link

@juanvallejo @soltysh Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP - it looks like this is the KEP for this enhancement https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/0024-kubectl-plugins.md - but let me know if that is not correct

@soltysh
Copy link
Contributor

soltysh commented Jan 16, 2019

@claurence that KEP is the right one. The scope of work will be to promote this feature to GA in 1.14, based on initial comment.
/milestone v1.14

@k8s-ci-robot k8s-ci-robot removed this from the v1.13 milestone Jan 16, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Jan 16, 2019
@claurence
Copy link

@juanvallejo @soltysh Hello - looking at the KEP it is marked as "provisional" - what more work is needed for it to be "implementable"?

Additionally are there any open PRs in k/k that we should track for the 1.14 release?

@soltysh
Copy link
Contributor

soltysh commented Feb 12, 2019

@juanvallejo @soltysh Hello - looking at the KEP it is marked as "provisional" - what more work is needed for it to be "implementable"?

I'll update the KEP accordingly.

Additionally are there any open PRs in k/k that we should track for the 1.14 release?

Only documentation fixes stating the mechanism is GA are required at this point in time.

I'll open both PRs tomorrow.

@jaredbhatti
Copy link

Heya, I'm working on tracking docs for the v1.14 launch. Has a docs PR been filed for this already? (It's not due until March 1st, just being proactive)

@tamalsaha
Copy link
Member

Any plans to support shadowing for CRDs? For example, I want to provide a custom view for kubectl describe <MyCRD> name .

@lachie83
Copy link
Member

Hello @jaredbhatti @soltysh, 1.14 enhancement shadow here. Code Freeze is March 7th and all PRs must be merged by then to your issue to make the 1.14 release. What open K/K PRs do you still have that need to merge? Thanks

@soltysh
Copy link
Contributor

soltysh commented Feb 26, 2019

Any plans to support shadowing for CRDs? For example, I want to provide a custom view for kubectl describe <MyCRD> name .

That's still being discussed, but we're quite hesitant since that might introduce hard to debug behavior. For kubectl describe itself we're planning to have a server-side version of it, similarly to kubectl get.

@soltysh
Copy link
Contributor

soltysh commented Feb 26, 2019

@lachie83 @jaredbhatti @claurence sorry for the delay, but here it goes, the updated KEP (to implemented) is #856 and doc update is here: kubernetes/website#12847

@spiffxp
Copy link
Member

spiffxp commented Mar 19, 2019

/remove-stage beta
/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Mar 19, 2019
@soltysh
Copy link
Contributor

soltysh commented Mar 26, 2019

Now that 1.14 is out the door I think we can close this issue since we've reached its final state.

@soltysh soltysh closed this as completed Mar 26, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 15, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests