Correct docs to explain how loadBalancerIP can be specified for the internal service

[AlexPykavy]

Docs update only.

What this PR does / why we need it:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.
• Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

• CLI change
• API change
• UI change
• configuration schema change
• behavioral change
• change in non-functional attributes such as efficiency or availability, availability of a new platform
• a warning about a deprecation
• fix of a previous Known Issue
• fix of a vulnerability (CVE)

No release notes are required for changes to the following:

• Tests
• Build infrastructure
• Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

PLACE RELEASE NOTES HERE 

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: AlexPykavy / name: Alexander Pykavy (ace7539)

[k8s-ci-robot]

@AlexPykavy: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @AlexPykavy!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @AlexPykavy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

@AlexPykavy On AWS, the LB is a FQDN and not an ipaddress. Will this take care of that scene ?

[AlexPykavy]

@AlexPykavy On AWS, the LB is a FQDN and not an ipaddress. Will this take care of that scene ?

@longwuyuan , I'm updating the documentation for the existing functionality and don't invent something new only but I'll try to answer to your question)

As Kubernetes docs states, loadBalancerIP service attribute is supported only for some cloud providers. For AWS, I found that it seems to be achieved by using annotations.

[AlexPykavy]

@ChiefAlexander, @cpanato, any comments?

[longwuyuan]

• I read the stackoverflow link but I am not convinced that introduction of that file .gitattributes in this project has been tested, verified and that everyone feels confident that there will be no undesired result of adding that .gitattrinutes file. I would not want to risk it at this stage. Maybe after a proper review from @rikatz @strongjz @tao12345666333

• The intended addition of explicit content on a "internal" LB seems a improvement at first glance

• The thought process behind using a "internal" LB are far more detailed than a few simple lines. Beginning with the existence of the a "internal" and a "external" network, and the corresponding cloud-controller-manager possibilities, there is DNS mapping and so much more involved. I am not sure if this PR should limit itself to just adding one sentence on the topic, or if there should be proper full scope content related to a "internal" LB

• The helm chart README is autogenerated using the helm-docs tool. Description is here https://github.com/kubernetes/ingress-nginx/blob/main/RELEASE.md#d-edit-the-valuesyaml-and-run-helm-docs . I am suspecting that the change committed here did not use the helm-docs tool. Should be a easy fox to use helm-docs

[AlexPykavy]

• I read the stackoverflow link but I am not convinced that introduction of that file .gitattributes in this project has been tested, verified and that everyone feels confident that there will be no undesired result of adding that .gitattrinutes file. I would not want to risk it at this stage. Maybe after a proper review from @rikatz @strongjz @tao12345666333

For some reason I faced the issue with automatic change of line encodings in the generated README.md file but I can't reproduce it now. Maybe it's my local issue with Git, VSCode or smth else. I just remember that having .gitattributes in the root of the repository should prevent changing EOL of the files already committed in the repo. So, I removed this for now.

• The intended addition of explicit content on a "internal" LB seems a improvement at first glance
• The thought process behind using a "internal" LB are far more detailed than a few simple lines. Beginning with the existence of the a "internal" and a "external" network, and the corresponding cloud-controller-manager possibilities, there is DNS mapping and so much more involved. I am not sure if this PR should limit itself to just adding one sentence on the topic, or if there should be proper full scope content related to a "internal" LB

I agree that giving more details is always better but external and internal terminology seems confusing because you can easily use default (external) service as internal one if you don't expose LB to the global by settings the appropriate annotations. We could just name the services first and second and get exactly the same behavior.

• The helm chart README is autogenerated using the helm-docs tool. Description is here https://github.com/kubernetes/ingress-nginx/blob/main/RELEASE.md#d-edit-the-valuesyaml-and-run-helm-docs . I am suspecting that the change committed here did not use the helm-docs tool. Should be a easy fox to use helm-docs

I used the tool but I did it on Windows and got some extra whitespace characters. Then I tried it inside the Docker container and it worked fine, so the committed docs are autogenerated as expected.

[tao12345666333]

/assign

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlexPykavy
Once this PR has been reviewed and has the lgtm label, please ask for approval from tao12345666333. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tao12345666333]

/ok-to-test

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rikatz]

Please rebase
/assign @Gacko

[Gacko]

I closed this PR as it is outdated. The related docs already have been updated ages ago.