Allow for some coredns customization #5839

Globegitter · 2018-09-26T21:00:22Z

I wanted to be able to enable autopath config and thought I would also try and fix #5773 along the way and add a few other minor changes. Imo the update strategy of kube-dns made more sense to have maxUnavailable set to 0. What do you think?

I also haven't tested the cache setting, but I think by having it a string, the full control should be possible including the extended config

cache [TTL] [ZONES...] {
    success CAPACITY [TTL]
    denial CAPACITY [TTL]
    prefetch AMOUNT [[DURATION] [PERCENTAGE%]]
}

by just using a yaml multi-line string.

This is the first PR of this nature that I have done btw, so hope modified everything at the right place.

k8s-ci-robot · 2018-09-26T21:00:32Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Globegitter
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kashifsaadat

If they are not already assigned, you can assign the PR to them by writing /assign @kashifsaadat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rajansandeep · 2018-09-26T21:05:14Z

/ok-to-test

Globegitter · 2018-09-26T21:05:29Z

Or as another idea, could we possibly just have KubeDNS.Corefile as a string and allow the whole corefile to be overwritten? That way everything could be customized and that should also allow for #5685 and any other cases that might come up in the future.

rochacon · 2018-10-04T03:44:23Z

upup/models/cloudup/resources/addons/coredns.addons.k8s.io/k8s-1.6.yaml.template

@@ -62,10 +62,13 @@ data:
          upstream
          fallthrough in-addr.arpa ip6.arpa
        }
+        {{ if KubeDNS.Corefile.EnableAutopath -}}
+        autpath @kubernetes


Is this a typo? autpath -> autopath?

rochacon · 2018-10-04T03:46:06Z

upup/models/cloudup/resources/addons/coredns.addons.k8s.io/k8s-1.6.yaml.template

@@ -84,7 +87,8 @@ spec:
  strategy:
    type: RollingUpdate
    rollingUpdate:
-      maxUnavailable: 1
+      maxSurge: 10%
+      maxUnavailable: 0


I've been investigating some DNS issues related to cluster rolling-updates, this seems related.

rochacon · 2018-10-04T04:03:36Z

@Globegitter I like your idea of being able to replace the entire Corefile, so any customization is possible. I'm currently interested in disabling DNS resolution logs.
However I'm a bit confused regarding the current implementation and how the cluster spec yaml would look like with the current approach.

In my understanding the new spec key in the cluster spec yaml should replace the entire content of the Corefile Configmap and the use would be like this:

# cluster.spec.yaml
apiVersion: kops/v1alpha2
kind: Cluster
metadata:
  name: my-cluster
spec:
  kubeDNS:
    provider: CoreDNS
  coreDNS:
    version: 1.2.2
    Corefile: |
      . {
        whoami
      }

The current implementation have keys to autopath (specific feature) and version (this is nice and I've incorporated in the example above, a bit differently).

Could you provide some examples on how you think the cluster spec should be? What are your thoughts on the approach described above?

Thank you for contributing this!

Globegitter · 2018-10-16T08:15:52Z

@rochacon Sorry I have been away on holiday and not sure I left it in a completely working state beforehand. I'll get back to it in the coming day. But yes your example is how it should be working.

k8s-ci-robot · 2018-10-28T19:15:47Z

@Globegitter: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

justinsb · 2018-11-19T12:02:12Z

Looks like a rebase is needed.

The other challenge is that some of these are CoreDNS specific, but we're in the generic kubedns configuration file. It's not terrible, but it makes me a little uneasy.

So I'm hoping that we're going to have a better way to manage addons in general in kops 1.12 / 1.13 - based around channels and kustomize, so we might be able to get this functionality without having to plumb everything through the API :-)

Moving to the next milestone anyway, as we're in the final burndown for 1.11

/milestone 1.12

fejta-bot · 2019-02-17T12:06:10Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

justinsb · 2019-03-18T02:35:06Z

Thanks again for this @Globegitter

We discussed in office-hours today the need to prioritize bug fixes until we can get 1.12 out (which will hopefully mean we get to everything faster overall), and I believe this is a feature, so I'm going to move this to the next release.

/kind feature
/milestone 1.13

fejta-bot · 2019-04-17T02:49:14Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

gerricchaplin · 2019-04-17T08:44:28Z

/remove-lifecycle rotten

Pajk · 2019-05-20T08:48:02Z

FYI the current CoreDNS version (1.3.1) used by Kops has a bug causing the CoreDNS failure when the kubernetes api is down. The option to change the CoreDNS version would be really helpful.

coredns/coredns#2629

There's a workaround - mount an EmptyDir to /tmp.

kubernetes/kubernetes#75414 (comment)

fejta-bot · 2019-08-18T09:15:54Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

k8s-ci-robot · 2019-08-18T09:16:00Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fejta-bot · 2019-09-17T10:00:08Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

Globegitter · 2019-09-19T09:02:23Z

Sorry, for not responding, I will not have time for this anymore.

Globegitter added 2 commits September 26, 2018 22:50

Add customization options for CoreDNS.

13aa945

Allow image version to be customized.

2c8cfab

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2018

k8s-ci-robot requested review from chrisz100 and rdrgmnzs September 26, 2018 21:00

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2018

Globegitter changed the title ~~coredns config~~ Allow for some coredns customization Sep 26, 2018

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 26, 2018

Globegitter added 2 commits September 26, 2018 23:47

Fix cache reference.

2a462c8

Add config to v1alpha1.

8fd41dd

rochacon reviewed Oct 4, 2018

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2018

justinsb added this to the 1.12 milestone Nov 19, 2018

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2019

justinsb added the area/addon-manager label Mar 15, 2019

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 18, 2019

justinsb modified the milestones: 1.12, 1.13 Mar 18, 2019

gjtempleton mentioned this pull request Jul 31, 2019

Feature Request: CoreDNS CoreFile fully configurable #7347

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2019

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 18, 2019

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 17, 2019

Globegitter closed this Sep 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow for some coredns customization #5839

Allow for some coredns customization #5839

Globegitter commented Sep 26, 2018 •

edited

Loading

k8s-ci-robot commented Sep 26, 2018

rajansandeep commented Sep 26, 2018

Globegitter commented Sep 26, 2018

rochacon Oct 4, 2018

rochacon Oct 4, 2018

rochacon commented Oct 4, 2018

Globegitter commented Oct 16, 2018

k8s-ci-robot commented Oct 28, 2018

justinsb commented Nov 19, 2018

fejta-bot commented Feb 17, 2019

justinsb commented Mar 18, 2019

fejta-bot commented Apr 17, 2019

gerricchaplin commented Apr 17, 2019

Pajk commented May 20, 2019 •

edited

Loading

fejta-bot commented Aug 18, 2019

k8s-ci-robot commented Aug 18, 2019

fejta-bot commented Sep 17, 2019

Globegitter commented Sep 19, 2019

Allow for some coredns customization #5839

Allow for some coredns customization #5839

Conversation

Globegitter commented Sep 26, 2018 • edited Loading

k8s-ci-robot commented Sep 26, 2018

rajansandeep commented Sep 26, 2018

Globegitter commented Sep 26, 2018

rochacon Oct 4, 2018

Choose a reason for hiding this comment

rochacon Oct 4, 2018

Choose a reason for hiding this comment

rochacon commented Oct 4, 2018

Globegitter commented Oct 16, 2018

k8s-ci-robot commented Oct 28, 2018

justinsb commented Nov 19, 2018

fejta-bot commented Feb 17, 2019

justinsb commented Mar 18, 2019

fejta-bot commented Apr 17, 2019

gerricchaplin commented Apr 17, 2019

Pajk commented May 20, 2019 • edited Loading

fejta-bot commented Aug 18, 2019

k8s-ci-robot commented Aug 18, 2019

fejta-bot commented Sep 17, 2019

Globegitter commented Sep 19, 2019

Globegitter commented Sep 26, 2018 •

edited

Loading

Pajk commented May 20, 2019 •

edited

Loading