handler: convert int types correctly like yaml2 does and gnostic expects

[sttts]

Json always unmarshals to float64, yaml2 does best effort down-sizing of the returned numbers, returning int, int64, uint64 or float64. Gnostic expects the later.

[sttts]

/assign @liggitt @mbohlool

[soltysh]

/lgtm

[apelisse]

I'm curious why this is not using sigs.k8s.io/yaml1 that has a JSonToYaml method built-in, which, according to a comment2 already does that properly.

[sttts]

I'm curious why this is not using sigs.k8s.io/yaml1 that has a JSonToYaml method built-in, which, according to a comment2 already does that properly.

Because it is slow. The one here avoids going through []byte. This was one of bottlenecks in OpenAPI merges. Hence, we optimized it.

Though I wouldn't mind moving this one over to the other repo. Wdyt?

[apelisse]

is it limited to an interface problem or an implementation? I'm asking because I wonder if we can improve the situation in general as opposed to just in this repo.

[sttts]

@apelisse I have created kubernetes-sigs/yaml#14. Can we please merge this first to fix this critical bug? I will create a follow-up with revendoering sig.k8s.io/yaml as soon as the upper PR merged.

[sttts]

@mbohlool is this approved?

[sttts]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[apelisse]

Can we please merge this first to fix this critical bug?

Too late, but yes :-)

[apelisse]

And really appreciate that you opened that PR!