Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for HA to beta #1567

Closed
8 tasks done
fabriziopandini opened this issue May 15, 2019 · 10 comments
Closed
8 tasks done

Tracking issue for HA to beta #1567

fabriziopandini opened this issue May 15, 2019 · 10 comments

Comments

@fabriziopandini
Copy link
Member

fabriziopandini commented May 15, 2019

What is missing for getting HA to beta in v1.15?

@fabriziopandini
Copy link
Member Author

@neolit123 opinions about the E2E part? the main idea behind is to not recreate a new series of job for HA, but instead, make current jobs have an additional control plane node so they are testing also HA

@neolit123
Copy link
Member

“--experimental-upload-certs” flag to be renamed “--upload-certs”. Default to true?

needs discussion with the group.

“kubeadm upgrade node experimental-control-plane” to be merged into “kubeadm upgrade node”

i'd be interested in how the detection will work here.

@neolit123 opinions about the E2E part? the main idea behind is to not recreate a new series of job for HA, but instead, make current jobs have an additional control plane node so they are testing also HA

+1 on switching everything to HA.

create a new job testing HA + automatic copy certificates with external etcd

seems good. i think we can get away without upgrade for external etcd for the beta...

@neolit123
Copy link
Member

+1 on switching everything to HA.

also i can work on these if you'd like.

@RA489
Copy link
Contributor

RA489 commented May 16, 2019

@fabriziopandini i can work on some of them.
“--experimental-control-plane” flag to be renamed “--control-plane”
“--experimental-upload-certs” flag to be renamed “--upload-certs”. Default to true?

@neolit123
Copy link
Member

hi @RA489 we spoke about these during yesterday's kubeadm office hours.
the idea was to do these PR last from the list from the list above.

also i think instead of renaming --experimental-control-plane -> --control-plane it might be better to have a transitional period of supporting both frags at the same time - e.g. at least 3 months.

@RA489
Copy link
Contributor

RA489 commented May 16, 2019

@neolit123 thanks for the explanation. let me know if i can help with some others PR

@RA489
Copy link
Contributor

RA489 commented May 23, 2019

@fabriziopandini I can look into change kind-master job (and possibly kind-1.14) to test HA

@neolit123
Copy link
Member

neolit123 commented Jun 10, 2019

create a new job testing HA + automatic copy certificates with external etcd

this is the only remaining item - PR is in flight; waits on test-grid merge approval:
kubernetes/test-infra#12906

[punted to v1.16] #1432 make join --control-plane more resilient (it should work after loosing one control plane/etcd) kubernetes/kubernetes#75600

this is a nice to have marked as priority/backlog and can be a post-beta improvement.

@fabriziopandini
Copy link
Member Author

/close
As per comment above the latest open issue be a post-beta improvement and it is already tracked in #1432

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closing this issue.

In response to this:

/close
As per comment above the latest open issue be a post-beta improvement and it is already tracked in #1432

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants