Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kubeadm able to consume CI images #337

Closed
luxas opened this issue Jul 5, 2017 · 8 comments · Fixed by kubernetes/kubernetes#49119
Closed

Make kubeadm able to consume CI images #337

luxas opened this issue Jul 5, 2017 · 8 comments · Fixed by kubernetes/kubernetes#49119
Labels
area/releasing area/test area/UX priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@luxas
Copy link
Member

luxas commented Jul 5, 2017

Now that kubernetes/test-infra#1400 is implemented, we can go on and make it possible to do

$ kubeadm init --kubernetes-version master

or

$ kubeadm init --kubernetes-version HEAD

or

$ kubeadm init --kubernetes-version ci/latest

or

$ kubeadm init --kubernetes-version latest-ci

What do people prefer?
What would basically happen is that the repository prefix would automatically get adjusted to gcr.io/kubernetes-ci-images and the latest available tag would be fetched like this (pseudo-code):

$ curl -sSL dl.k8s.io/ci-cross/latest.txt
v1.8.0-alpha.1.608+992002689e3c54

Then kubeadm will go on and use those images super easily 🎉

This will unblock #238

@luxas luxas added area/releasing area/test area/UX kind/enhancement priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 5, 2017
@luxas luxas added this to the v1.8 milestone Jul 5, 2017
@namliz
Copy link

namliz commented Jul 6, 2017

That's awesome. I think it ought to be possible to override the repository prefix.

@luxas
Copy link
Member Author

luxas commented Jul 6, 2017

@Zilman It has been possible to override repository prefix since v1.5-ish, but it hasn't been well documented other than on the kubeadm reference docs on the site. It has been possible using the environment variable KUBE_REPO_PREFIX. However, that's being moved to the API in v1.8, ref: #326

However, being able to consume the latest CI builds automatically is exciting as well!

@ixdy
Copy link
Member

ixdy commented Jul 6, 2017

cluster/get-kube.sh and kubetest use the ci/latest (or ci/latest-1.7, etc) form, so that seems most consistent with existing tooling.

@luxas
Copy link
Member Author

luxas commented Jul 10, 2017

@andrewrynhard volunteered to contribute this 🎉
Ask if you need anything

@kad
Copy link
Member

kad commented Jul 10, 2017

consistency is a key. if we have "latest", "latest-1.7" and so on for releases, same should be for "ci/".

@kad
Copy link
Member

kad commented Jul 10, 2017

@luxas @andrewrynhard if you don't mind, I'll take that issue, I have some early days drafts for it.

@andrewrynhard
Copy link

@kad Don't mind at all.

kad added a commit to kad/kubernetes that referenced this issue Aug 15, 2017
kad added a commit to kad/kubernetes that referenced this issue Aug 18, 2017
kad added a commit to kad/kubernetes that referenced this issue Aug 18, 2017
@luxas
Copy link
Member Author

luxas commented Aug 22, 2017

Great to have this issue closed, thanks @kad!

jessicaochen pushed a commit to jessicaochen/kubernetes that referenced this issue Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/releasing area/test area/UX priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants