Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long deprecated gitrepo volume plugin from code base #126041

Closed
saad-ali opened this issue Jul 12, 2024 · 5 comments
Closed

Remove long deprecated gitrepo volume plugin from code base #126041

saad-ali opened this issue Jul 12, 2024 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@saad-ali
Copy link
Member

What happened?

In SIG Storage Meeting today, @bswartz pointed out that gitrepo in-tree volume was deprecated a long time ago (see #60999) but the code is still around and may have vulnerabilities.

We should consider removing it.

What did you expect to happen?

It looks like completely removing the API/code would have been considered a backwards incompatible change which k8s avoids, and so only a deprecation notice was created and the code was left as is see #63445 (comment)

We have been able to get rid of other in-tree plugins by keeping the API and implementing "CSI migration" which enables the implementation to be removed and redirect to new CSI drivers. In this case there is no "CSI" migration -- instead the recommendation is to use emptyDir + initContainers.

To remove risk from the unmaintained code -- I suggest that we keep the API, but remove the implementation. (We did exactly this with Flocker, for example, see #111618)

How can we reproduce it (as minimally and precisely as possible)?

N/A

Anything else we need to know?

No response

Kubernetes version

1.30

Cloud provider

N/A

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

@saad-ali saad-ali added the kind/bug Categorizes issue or PR as related to a bug. label Jul 12, 2024
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 12, 2024
@saad-ali
Copy link
Member Author

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 12, 2024
@saad-ali
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 12, 2024
@saad-ali
Copy link
Member Author

/assign @noctarius
Chris indicated on Slack he's interested in driving this.

@k8s-ci-robot
Copy link
Contributor

@saad-ali: GitHub didn't allow me to assign the following users: noctarius.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @noctarius
Chris indicated on Slack he's interested in driving this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert
Copy link
Member

duplicate of #125983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants