Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print additional columns for RuntimeClass CRD #72446

Merged
merged 1 commit into from
Jan 5, 2019
Merged

Print additional columns for RuntimeClass CRD #72446

merged 1 commit into from
Jan 5, 2019

Conversation

Huang-Wei
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Without this PR, runtimeclass obj is printed with name and age columns:

$ k get runtimeclass
NAME         AGE
containerd   16h

After leveraging additionalPrinterColumns feature of CRD (since 1.11), more meaningful columns can be printed out:

$ k apply -f runtimeclass-crd.yaml
customresourcedefinition.apiextensions.k8s.io/runtimeclasses.node.k8s.io configured
$ k get runtimeclass
NAME         RUNTIME-HANDLER   AGE
containerd   runc              16h

Does this PR introduce a user-facing change?:

RuntimeClass is now printed with extra `RUNTIME-HANDLER` column.

/sig node
/assign @tallclair

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 30, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Dec 30, 2018
@Huang-Wei
Copy link
Member Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 30, 2018
yastij
yastij approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 31, 2018
feiskyer
feiskyer reviewed Jan 1, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tallclair
Copy link
Member

/lgtm

@tallclair
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2019
@Huang-Wei
Copy link
Member Author

/retest

krmayankk
krmayankk reviewed Jan 3, 2019
View reviewed changes
Copy link

@krmayankk krmayankk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice , since what version of kubernetes has this feature been available

@Huang-Wei
Copy link
Member Author

/retest

@Huang-Wei
Copy link
Member Author

@krmayankk 1.11, see additional-printer-columns

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@yastij
Copy link
Member

yastij commented Jan 3, 2019

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@yastij
Copy link
Member

yastij commented Jan 3, 2019

/lgtm cancel

Until gke-e2e is fixed

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2019
@Huang-Wei
Copy link
Member Author

/test pull-kubernetes-e2e-gke

@Huang-Wei
Copy link
Member Author

It's weird that the change results in a GKE e2e failure. I looked through the log and it says:

W0105 02:57:43.126]  detail: u'All cluster resources were brought up, but the cluster API is reporting that: only 0 nodes out of 4 have registered; cluster may be unhealthy.'
...
W0105 02:57:43.128]  zone: u'us-central1-f'>] finished with error: All cluster resources were brought up, but the cluster API is reporting that: only 0 nodes out of 4 have registered; cluster may be unhealthy.

And the specific error says:

W0105 03:15:01.281] 2019/01/05 03:15:01 main.go:313: Something went wrong: starting e2e cluster: error creating cluster: error during gcloud container clusters create --quiet --addons=HttpLoadBalancing,HorizontalPodAutoscaling,KubernetesDashboard --project=gke-up-g1-3-c1-5-up-clu-n --zone=us-central1-f --machine-type=n1-standard-2 --image-type=gci --num-nodes=4 --network=e2e-3828-218b6 --cluster-version=1.14.0-alpha.0.1437+43fb55c486e080-pull-kubernetes-e2e-gke e2e-3828-218b6: exit status 1
W0105 03:15:01.285] Traceback (most recent call last):
W0105 03:15:01.285]   File "/workspace/./test-infra/jenkins/../scenarios/kubernetes_e2e.py", line 758, in <module>
W0105 03:15:01.372]     main(parse_args())
W0105 03:15:01.373]   File "/workspace/./test-infra/jenkins/../scenarios/kubernetes_e2e.py", line 609, in main
W0105 03:15:01.373]     mode.start(runner_args)
W0105 03:15:01.373]   File "/workspace/./test-infra/jenkins/../scenarios/kubernetes_e2e.py", line 262, in start
W0105 03:15:01.373]     check_env(env, self.command, *args)
W0105 03:15:01.373]   File "/workspace/./test-infra/jenkins/../scenarios/kubernetes_e2e.py", line 111, in check_env
W0105 03:15:01.373]     subprocess.check_call(cmd, env=env)
W0105 03:15:01.373]   File "/usr/lib/python2.7/subprocess.py", line 186, in check_call
W0105 03:15:01.403]     raise CalledProcessError(retcode, cmd)
W0105 03:15:01.404] subprocess.CalledProcessError: Command '('kubetest', '--dump=/workspace/_artifacts', '--gcp-service-account=/etc/service-account/service-account.json', '--build=bazel', '--stage=gs://kubernetes-release-dev/ci', '--up', '--down', '--test', '--deployment=gke', '--provider=gke', '--cluster=e2e-3828-218b6', '--gcp-network=e2e-3828-218b6', '--extract=local', '--gcp-cloud-sdk=gs://cloud-sdk-testing/ci/staging', '--gcp-node-image=gci', '--gcp-zone=us-central1-f', '--ginkgo-parallel=30', '--gke-create-command=container clusters create --quiet --addons=HttpLoadBalancing,HorizontalPodAutoscaling,KubernetesDashboard', '--gke-environment=test', '--gke-shape={"default":{"Nodes":4,"MachineType":"n1-standard-2"}}', '--stage-suffix=pull-kubernetes-e2e-gke', '--test_args=--ginkgo.flakeAttempts=2 --ginkgo.skip=\\[Slow\\]|\\[Serial\\]|\\[Disruptive\\]|\\[Flaky\\]|\\[Feature:.+\\] --minStartupPods=8', '--timeout=65m')' returned non-zero exit status 1
E0105 03:15:01.413] Command failed
I0105 03:15:01.413] process 520 exited with code 1 after 57.5m

@kubernetes/sig-testing Could you give a hand on diagnosing this? Thanks in advance.

/sig testing

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jan 5, 2019
@yastij
Copy link
Member

yastij commented Jan 5, 2019

@Huang-Wei - it was broken, see run across PRs.

@yastij
Copy link
Member

yastij commented Jan 5, 2019

/retest

@Huang-Wei
Copy link
Member Author

@yastij Thanks! Could you re-label /lgtm?

@yastij
Copy link
Member

yastij commented Jan 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 815acf7 into kubernetes:master Jan 5, 2019
@Huang-Wei Huang-Wei deleted the runtimclass-crd-print branch January 6, 2019 01:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@krmayankk krmayankk krmayankk left review comments

@yastij yastij yastij approved these changes

Assignees

@yastij yastij

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Huang-Wei @tallclair @k8s-ci-robot @fejta-bot @yastij @feiskyer @krmayankk