Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet service links error #74529

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Kubelet service links error #74529

merged 2 commits into from
Mar 5, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Feb 25, 2019 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:

xref #71749

Does this PR introduce a user-facing change?:

Fixes panic if a kubelet is run against an older kube-apiserver

/sig node
/cc @dims @tallclair @joejulian

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 25, 2019
@k8s-ci-robot
Copy link
Contributor

@liggitt: GitHub didn't allow me to request PR reviews from the following users: joejulian.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it:

Does this PR introduce a user-facing change?:

Fixes panic if a kubelet is run against an older kube-apiserver

/sig node
/cc @dims @tallclair @joejulian

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 25, 2019
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Feb 25, 2019
@liggitt liggitt mentioned this pull request Feb 25, 2019
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2019
@liggitt liggitt added this to the v1.14 milestone Mar 5, 2019
@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 5, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 5, 2019
@liggitt
Copy link
Member Author

liggitt commented Mar 5, 2019

ping @dims / @tallclair

@dims
Copy link
Member

dims commented Mar 5, 2019

/lgtm

Thanks for taking care of this @liggitt. Do we have any CI jobs that test this scenario? (curious)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2019
@liggitt
Copy link
Member Author

liggitt commented Mar 5, 2019

Do we have any CI jobs that test this scenario? (curious)

we don't have CI jobs that set up unsupported configurations that that I know of

@k8s-ci-robot k8s-ci-robot merged commit 0a4308f into kubernetes:master Mar 5, 2019
@liggitt liggitt deleted the kubelet-service-links-error branch March 6, 2019 06:10
@liggitt liggitt mentioned this pull request Jun 13, 2019
Closed
@rdrgmnzs rdrgmnzs mentioned this pull request Jul 25, 2019
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @k8s-ci-robot @dims