Allow disable outbound snat when Azure standard load balancer is used #75282
+32
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
Added to v1.14 since it is a critical bug fix. /kind bug |
k8s-ci-robot
added
sig/azure
priority/critical-urgent
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @andyzhangx @khenidak |
|
/test pull-kubernetes-e2e-aks-engine-azure |
k8s-ci-robot
added
the
sig/cloud-provider
andyzhangx
reviewed
Mar 12, 2019
feiskyer
force-pushed
the
disable-outboud-snat
branch
from
98b8573
to
84617c8
Compare
|
/test pull-kubernetes-e2e-aks-engine-azure |
k8s-ci-robot
added
the
lgtm
|
/retest |
1 similar comment
|
/retest |
|
/retest Review the full test history for this PR. Silence the bot with an |
|
/retest |
This was referenced Mar 13, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 14, 2019
…82-upstream-release-1.12 Automated cherry pick of #75282: Allow disable outbound snat when Azure standard load balancer
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 19, 2019
…82-upstream-release-1.13 Automated cherry pick of #75282: Allow disable outbound snat when Azure standard load balancer
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 21, 2019
…82-upstream-release-1.11 Automated cherry pick of #75282: Allow disable outbound snat when Azure standard load balancer
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Azure outbound rules are not taking effect when used together with standard load balancer .
This PR adds a new configuration for disabling SNAT for load balancer rules, so that outbound rules would be used as the egress IPs.
In such case, disableOutboundSNAT should be set to true and loadBalancerSku should be set to standard.
Which issue(s) this PR fixes:
Fixes #75281
Special notes for your reviewer:
Does this PR introduce a user-facing change?: