Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Framework] Add UnschedulableAndUnresolvable status code #82034

Merged
merged 1 commit into from
Aug 30, 2019
Merged

[Framework] Add UnschedulableAndUnresolvable status code #82034

merged 1 commit into from
Aug 30, 2019

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Aug 27, 2019 •
edited
Loading

The status can be used by (Pre)Filter plugins to indicate that preemption wouldn't change the decision of the filter.

/kind feature

What this PR does / why we need it:

It allows the scheduler to skip preemption if it wouldn't change the results of the filters.

Which issue(s) this PR fixes:

Fixes #80775

Special notes for your reviewer:

This might need a rebase if #81876 gets merged first.

Does this PR introduce a user-facing change?:

Add UnschedulableAndUnresolvable status code for Scheduler Framework

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 27, 2019
@alculquicondor
Copy link
Member Author

alculquicondor commented Aug 27, 2019 •
edited
Loading

/assign @wgliang

cc/ @bsalamat @ahg-g

@alculquicondor
Copy link
Member Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 28, 2019
draveness
draveness suggested changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@draveness draveness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @Huang-Wei @ahg-g

We may need to file an exception if we don't get it merged tomorrow.

@ahg-g
Copy link
Member

ahg-g commented Aug 28, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2019
@ahg-g
Copy link
Member

ahg-g commented Aug 28, 2019

/test pull-kubernetes-integration

@alculquicondor
[Framework] Add UnschedulableAndUnresolvable status code
3c1f8a8 
The status can be used by (Pre)Filter plugins to indicate that
preemption wouldn't change the decision of the filter.

Signed-off-by: Aldo Culquicondor <acondor@google.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2019
@alculquicondor
Copy link
Member Author

I just removed the change in test/integration/daemonset as it was a left over from a previous approach.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2019
@ahg-g
Copy link
Member

ahg-g commented Aug 28, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 30, 2019 •
edited
Loading

@alculquicondor: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-conformance-kind-ipv6 d70b84a147df2d30400ce14bad9596d1b621aa50 link /test pull-kubernetes-conformance-kind-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@alculquicondor
Copy link
Member Author

/milestone v1.16

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Member Author

@bsalamat could you handle the milestone?

@ahg-g
Copy link
Member

ahg-g commented Aug 30, 2019

@k82cn can you apply 1.16 milestone please.

@k82cn
Copy link
Member

k82cn commented Aug 30, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit b339689 into kubernetes:master Aug 30, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draveness draveness draveness requested changes

@foxish foxish Awaiting requested review from foxish

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@Huang-Wei Huang-Wei

@wgliang wgliang

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
8 participants
@alculquicondor @ahg-g @k8s-ci-robot @fejta-bot @k82cn @draveness @Huang-Wei @wgliang