Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scheduler): expose SharedInformerFactory to the framework handle #83663

Merged

Conversation

draveness
Copy link
Contributor

@draveness draveness commented Oct 9, 2019

/kind feature
/sig scheduling
/priority important-soon

What this PR does / why we need it:

Which issue(s) this PR fixes:

ref: #83523

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Expose SharedInformerFactory in the framework handle

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 9, 2019
@draveness draveness force-pushed the feature/add-shared-informers-factory branch from 736a4ac to 383f0ce Compare October 9, 2019 06:51
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 9, 2019
@draveness
Copy link
Contributor Author

/assign @ahg-g

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2019
@draveness
Copy link
Contributor Author

/retest

@draveness draveness requested a review from ahg-g October 10, 2019 07:03
@draveness draveness force-pushed the feature/add-shared-informers-factory branch from 4a5a833 to 9cd9168 Compare October 10, 2019 07:03
@ahg-g
Copy link
Member

ahg-g commented Oct 10, 2019

Thanks please squash.

/approve
/assign @msau42 for volume-related tests

@k8s-ci-robot
Copy link
Contributor

@ahg-g: GitHub didn't allow me to assign the following users: for, volume-related, tests.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Thanks please squash.

/approve
/assign @msau42 for volume-related tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@draveness
Copy link
Contributor Author

Thanks please squash.

done

@ahg-g
Copy link
Member

ahg-g commented Oct 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2019
@ahg-g
Copy link
Member

ahg-g commented Oct 10, 2019

@draveness: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration d7db0e2 link /test pull-kubernetes-integration
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

this seems like a legitimate failure, we should look closely into it.

@ahg-g
Copy link
Member

ahg-g commented Oct 10, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2019
@msau42
Copy link
Member

msau42 commented Oct 10, 2019

/approve
/lgtm cancel
to look into test failures

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2019
@ahg-g
Copy link
Member

ahg-g commented Oct 10, 2019

/test pull-kubernetes-integration

1 similar comment
@ahg-g
Copy link
Member

ahg-g commented Oct 10, 2019

/test pull-kubernetes-integration

@draveness draveness force-pushed the feature/add-shared-informers-factory branch from d7db0e2 to ee4dec6 Compare October 11, 2019 02:23
@draveness
Copy link
Contributor Author

draveness commented Oct 11, 2019

/approve
/lgtm cancel
to look into test failures

https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-integration-master/1179256637836234754

https://testgrid.k8s.io/google-unit#integration-master&include-filter-by-regex=NodePIDPre

It was a flaky test which fails since 10-02 (at least) when this PR wasn't opened. Please take another look, the previous approve does not work as expected.

@ahg-g
Copy link
Member

ahg-g commented Oct 11, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2019
@ahg-g
Copy link
Member

ahg-g commented Oct 11, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2019
@msau42
Copy link
Member

msau42 commented Oct 11, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, draveness, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit c980000 into kubernetes:master Oct 11, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 11, 2019
ohsewon pushed a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
…-informers-factory

feat(scheduler): expose SharedInformerFactory to the framework handle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants