Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert NodeLabelPresence custom predicate to filter plugin. #84297

Merged
merged 1 commit into from
Oct 26, 2019
Merged

Convert NodeLabelPresence custom predicate to filter plugin. #84297

merged 1 commit into from
Oct 26, 2019

Conversation

liu-cong
Copy link
Contributor

@liu-cong liu-cong commented Oct 24, 2019 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Part of scheduler framework migration.

Which issue(s) this PR fixes:

Part of #84187

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

User can now use component config to configure NodeLabel plugin for the scheduler framework.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 24, 2019
@liu-cong
Copy link
Contributor Author

sharing the draft to give you an idea and get some early feedback
cc @ahg-g

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 24, 2019
ahg-g
ahg-g reviewed Oct 25, 2019
View reviewed changes
Copy link
Member

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cong, the approach sounds good to me.

pkg/scheduler/apis/config/types.go Outdated Show resolved Hide resolved
pkg/scheduler/factory.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 25, 2019
@liu-cong liu-cong marked this pull request as ready for review October 25, 2019 18:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2019
@liu-cong
Copy link
Contributor Author

/assign ahg-g

ahg-g
ahg-g reviewed Oct 25, 2019
View reviewed changes
Copy link
Member

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits, looks good to me otherwise.

pkg/scheduler/algorithm_factory.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/nodelabel/node_label.go Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
@liu-cong liu-cong force-pushed the custompred branch 2 times, most recently from c0ecea7 to dd7b859 Compare October 25, 2019 21:11
@ahg-g
Copy link
Member

ahg-g commented Oct 26, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, liu-cong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2019
@ahg-g
Copy link
Member

ahg-g commented Oct 26, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 41730db into kubernetes:master Oct 26, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 26, 2019
This was referenced Oct 28, 2019
Closed
Closed
Closed
Closed
Closed
@ahg-g ahg-g mentioned this pull request Nov 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@draveness draveness Awaiting requested review from draveness

@resouer resouer Awaiting requested review from resouer

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
3 participants
@liu-cong @ahg-g @k8s-ci-robot