Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updating schedule.yaml as a release cut step #2294

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jul 27, 2023

What type of PR is this:

/kind documentation

What this PR does / why we need it:

This task tends to get forgotten from time to time which causes confusion for the end users. Adding it to the task list should serve as a reminder so that we don't forget about this after cutting the release.

Which issue(s) this PR fixes:

xref https://kubernetes.slack.com/archives/C2C40FMNF/p1690472726609569

/assign @saschagrunert @Verolop @cpanato
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 27, 2023
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jul 27, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2023
@xmudrii xmudrii added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 27, 2023
@jimangel
Copy link
Member

/lgtm

It really would be nice to have a better process here... but this is a great start!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Jul 27, 2023

@jimangel I hope that we can automate this somehow. I created kubernetes/release#3179 to follow up on that

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member Author

xmudrii commented Jul 28, 2023

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 773ae05 into kubernetes:master Jul 28, 2023
1 of 2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 28, 2023
@xmudrii xmudrii deleted the update-calendar branch July 28, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants