Replace ListTeamMembers with ListTeamMembersBySlug

[lanycrost]

Fixes #27685

I've added the GetTeamById function to the codebase to ensure backward compatibility, and I'm not happy about it, if you can purpose more reliable workaround, I'll happy to do.

If you have any plans to fully remove the deprecated functions, I'm fully supportive and ready to help.

[k8s-ci-robot]

Welcome @lanycrost!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @lanycrost. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[smg247]

/ok-to-test

[smg247]

This looks okay in general.

nit:
It may be nicer to abstract away the call to the getTeamById method inside the listTeamMembers method instead. That method could be preserved and just call the 2 others within.

The solution suggested in #25600 (comment) to have the peribolos config contain the org AND team name would likely allow you to not have to introduce this new method (and multiple API calls for one function). This would also be a heavier lift though.

[lanycrost]

@smg247 yeah, agree. It will be more accurate way, will do soon!

[lanycrost]

@smg247 in other hand I need to use here other deprecated API call see instead of ListTeamMembers :(

[lanycrost]

I will dig in documentation to find more clean way

[lanycrost]

@smg247 to avoid using of deprecated methods I suggest to use this method:

Note: You can also specify a team by org_id and team_id using the route GET /organizations/{org_id}/team/{team_id}.

In that case I will do 3 requests in ListTeamMembers function one for getting org_id, then I will use above mentioned call for retrieving team name, and in third call I will get team members.

In this scenario we will not use any deprecated call.

What you think about this?

[lanycrost]

https://docs.github.com/en/rest/teams/teams?apiVersion=2022-11-28#get-a-team-by-name

[lanycrost]

@chaodaiG What you think about above discussion?

[smg247]

If the peribolos config contained the org and team name (like org-name/team-name) wouldn't you only need one call to ListTeamMembersBySlug?

[lanycrost]

@smg247 @chaodaiG The problem, that I'm receiving team id (not the slug) in TeamHasMember function. I've replaced that function with TeamBySlugHasMember, but I'm not sure, may be we need to do manual steps to update CRD and other manifests?

[SergeyKanzhelev]

/approve

for the typo in sig-node owned file

[lanycrost]

/retest-required

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lanycrost, SergeyKanzhelev
Once this PR has been reviewed and has the lgtm label, please assign dims for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• config/OWNERS
• config/jobs/image-pushing/OWNERS
• prow/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lanycrost]

/retest

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@lanycrost: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-test-infra-prow-checkconfig	13768cd	link	true	/test pull-test-infra-prow-checkconfig
pull-test-infra-misc-image-build-test	13768cd	link	true	/test pull-test-infra-misc-image-build-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jihoon-seo]

Hello @lanycrost, the Prow source code has been moved to https://github.com/kubernetes-sigs/prow on April 9, 2024.
Please consider migrate this PR (by opening a new one in there).
Thanks!

[lanycrost]

Hey, @jihoon-seo! OK, thank you! Will do it soon.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.