Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster API: Consolidate IPv6 and dualstack jobs #29699

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Cluster API: Consolidate IPv6 and dualstack jobs #29699

merged 1 commit into from
Jun 6, 2023

Conversation

killianmuldoon
Copy link
Contributor

Remove the standalone IPv6 Cluster API jobs. These jobs are now run as part of a consolidated dualstack + ipv6 job. The IPv6 tag refers to any jobs that require IPv6 - i.e. both the IPv6 job and the dualstack jobs.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 6, 2023
@killianmuldoon
Copy link
Contributor Author

@sbueringer

@killianmuldoon killianmuldoon mentioned this pull request Jun 6, 2023
Merged
sbueringer
sbueringer reviewed Jun 6, 2023
View reviewed changes
config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml
@@ -109,7 +109,7 @@ periodics:
testgrid-tab-name: capi-e2e-main
testgrid-alert-email: sig-cluster-lifecycle-cluster-api-alerts@kubernetes.io
testgrid-num-failures-to-alert: "4"
- name: periodic-cluster-api-e2e-dualstack-ipv6-main
- name: periodic-cluster-api-e2e-dualstack-and-ipv6-main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also rename the tab(s)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@killianmuldoon
Cluster API: Consolidate IPv6 and dualstack jobs
62c8057 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 02459bb into kubernetes:master Jun 6, 2023
@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml
  • key cluster-api-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml

In response to this:

Remove the standalone IPv6 Cluster API jobs. These jobs are now run as part of a consolidated dualstack + ipv6 job. The IPv6 tag refers to any jobs that require IPv6 - i.e. both the IPv6 job and the dualstack jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@killianmuldoon @sbueringer @k8s-ci-robot