Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate label sync #32948

Merged
merged 3 commits into from
Jul 12, 2024
Merged

migrate label sync #32948

merged 3 commits into from
Jul 12, 2024

Conversation

BenTheElder
Copy link
Member

  • migrate label sync job to k8s infra
  • update migration TODO
  • clarify the file name for the other sig-testing trusted jobs that are migrated (metrics kettle)

part of #32432

TODO: #32947

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/label_sync Issues or PRs related to code in /label_sync sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Jul 10, 2024
@BenTheElder BenTheElder mentioned this pull request Jul 10, 2024
Closed
4 tasks
@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 10, 2024
@ameukam
Copy link
Member

ameukam commented Jul 11, 2024

/lgtm
/hold

cc @kubernetes/sig-contributor-experience-leads

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2024
@Priyankasaggu11929
Copy link
Member

/approve
/lgtm

from contribEx side (for the label sync job & README changes)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3961c42 into kubernetes:master Jul 12, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-testing-label-sync.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-testing-label-sync.yaml
  • key sig-test-infra.yaml using file ``
  • key sig-testing-metrics.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-testing-metrics.yaml
  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

  • migrate label sync job to k8s infra
  • update migration TODO
  • clarify the file name for the other sig-testing trusted jobs that are migrated (metrics kettle)

part of #32432

TODO: #32947

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder BenTheElder deleted the move-label-sync branch July 12, 2024 18:25
This was referenced Jul 12, 2024
Merged
Merged
@BenTheElder
Copy link
Member Author

I think the job migration part is going to be fine, but we need to start syncing the config to the cluster, which happens separately.

#32971 <--- configmap sync
#32970 <--- alerts

@BenTheElder
Copy link
Member Author

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-test-infra-label-sync/1811857405504393216 this is working now, but we still need the requested alerts update in #32970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

Assignees

@ameukam ameukam

@Priyankasaggu11929 Priyankasaggu11929

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/label_sync Issues or PRs related to code in /label_sync cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @ameukam @Priyankasaggu11929 @k8s-ci-robot