Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add presubmit to run node conformance with crun #33298

Closed
wants to merge 1 commit into from

Conversation

kannon92
Copy link
Contributor

Ref: #33300

Add a presubmit to test with crun versus runc.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 12, 2024
@BenTheElder
Copy link
Member

/hold

#33300

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2024
@aojea
Copy link
Member

aojea commented Aug 14, 2024

presubmits is not going to add you much value over periodics, these presubmits jobs will not be considered blocking ... once they start failing unless you have someone looking at the failures , it will have the same effect as a periodic

@kannon92
Copy link
Contributor Author

My main reason for a presubmit is to have a job to test periodica and to make sure that this actually works before creating the periodic.

@aojea
Copy link
Member

aojea commented Aug 14, 2024

My main reason for a presubmit is to have a job to test periodica and to make sure that this actually works before creating the periodic.

I see, so you want something in presubmit just to check the job is working fine to avoid iterating on the periodic

@BenTheElder I thought there was one documented way of achieving that , otherwise that looks a legit request if there is no alternative, though I think we should think in appending some word to indicate clear the purpose of the job , maybe -canary or something like that

@kannon92
Copy link
Contributor Author

@aojea I find that having a 1to1 correspondence to presubmits and periodics is very useful. I like to have some kind of confirmation on the PR that this would fix the periodic so I encourage people to add presubmits and periodics.

If there is a way that a pleeb like me can kick off a periodic out-of-band that would drastically reduce the jobs we have in sig-node. I know I've seen dims run a periodic job but I'm not sure that permission is given everywhere.

@kannon92 kannon92 closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants