-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add presubmit to run node conformance with crun #33298
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
presubmits is not going to add you much value over periodics, these presubmits jobs will not be considered blocking ... once they start failing unless you have someone looking at the failures , it will have the same effect as a periodic |
My main reason for a presubmit is to have a job to test periodica and to make sure that this actually works before creating the periodic. |
I see, so you want something in presubmit just to check the job is working fine to avoid iterating on the periodic @BenTheElder I thought there was one documented way of achieving that , otherwise that looks a legit request if there is no alternative, though I think we should think in appending some word to indicate clear the purpose of the job , maybe |
@aojea I find that having a 1to1 correspondence to presubmits and periodics is very useful. I like to have some kind of confirmation on the PR that this would fix the periodic so I encourage people to add presubmits and periodics. If there is a way that a pleeb like me can kick off a periodic out-of-band that would drastically reduce the jobs we have in sig-node. I know I've seen dims run a periodic job but I'm not sure that permission is given everywhere. |
Ref: #33300
Add a presubmit to test with crun versus runc.