Update documentation on CoreDNS #10923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit e6c3314 https://deploy-preview-10923--kubernetes-io-master-staging.netlify.com |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit d531e6b https://deploy-preview-10923--kubernetes-io-master-staging.netlify.com |
neolit123
reviewed
Nov 8, 2018
| @@ -103,7 +103,7 @@ The Corefile configuration includes the following [plugins](https://coredns.io/p | |||
| * [proxy](https://coredns.io/plugins/proxy/): Any queries that are not within the cluster domain of Kubernetes will be forwarded to predefined resolvers (/etc/resolv.conf). | |||
| * [cache](https://coredns.io/plugins/cache/): This enables a frontend cache. | |||
| * [loop](https://coredns.io/plugins/loop/): Detects simple forwarding loops and halts the CoreDNS process if a loop is found. | |||
| * [reload](https://coredns.io/plugins/reload): Allows automatic reload of a changed Corefile. | |||
| * [reload](https://coredns.io/plugins/reload): Allows automatic reload of a changed Corefile. After editing the configuration in the ConfigMap, allow 2 mins for these changes to take effect in CoreDNS. | |||
2 tasks
Fixed nit noted in comments and cleaned up a few more things while I was in there. This whole topic needs a complete redo, but this PR is an iterative improvment. Thanks!
k8s-ci-robot
added
language/en
|
added a few more copyedits, adding lgtm based on Lubomir's comment. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bradamant3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some minor changes to the documentation regarding CoreDNS